fix: cleanup

Author: neocybereth

apps/namadillo/src/App/Transactions/BundledTransactionCard.tsx

@@ -83,15 +83,10 @@ export const BundledTransactionCard: React.FC<Props> = ({
             <span className="font-mono text-sm">
               {shortenAddress(publicKey, 12, 12)}
             </span>
-            <div className="relative group/tooltip">
-              <CopyToClipboardControl
-                className="text-neutral-400"
-                value={publicKey}
-              />
-              <Tooltip position="left" className="p-2 w-[150px] z-10">
-                Copy public key
-              </Tooltip>
-            </div>
+            <CopyToClipboardControl
+              className="text-neutral-400"
+              value={publicKey}
+            />
           </h4>
         </div>
       </div>

apps/namadillo/src/App/Transactions/TransactionCard.tsx

@@ -262,10 +262,13 @@ const renderKeplrIcon = (address: string): JSX.Element | null => {
   return <img src={keplrSvg} height={18} width={18} />;
 };
 
-const ValidatorTooltip: React.FC<{
+const ValidatorTooltip = ({
+  validator,
+  children,
+}: {
   validator: Validator;
   children: React.ReactNode;
-}> = ({ validator, children }) => {
+}): JSX.Element => {
   return (
     <div className="relative group/tooltip cursor-pointer">
       {children}
@@ -330,11 +333,14 @@ const ValidatorTooltip: React.FC<{
   );
 };
 
-const TransactionCardContainer: React.FC<{
+const TransactionCardContainer = ({
+  children,
+  hasValidatorImage = false,
+}: {
   children: React.ReactNode;
   transactionFailed: boolean;
   hasValidatorImage?: boolean;
-}> = ({ children, hasValidatorImage = false }) => {
+}): JSX.Element => {
   return (
     <article
       className={twMerge(
@@ -351,12 +357,17 @@ const TransactionCardContainer: React.FC<{
   );
 };
 
-const TransactionHeader: React.FC<{
+const TransactionHeader = ({
+  transactionFailed,
+  title,
+  wrapperId,
+  timestamp,
+}: {
   transactionFailed: boolean;
   title: string;
   wrapperId?: string;
   timestamp?: number;
-}> = ({ transactionFailed, title, wrapperId, timestamp }) => {
+}): JSX.Element => {
   return (
     <div className="flex items-center gap-3">
       <i
@@ -413,10 +424,13 @@ const TransactionHeader: React.FC<{
   );
 };
 
-const TransactionAmount: React.FC<{
+const TransactionAmount = ({
+  asset,
+  amount,
+}: {
   asset: NamadaAsset | undefined;
   amount: BigNumber;
-}> = ({ asset, amount }) => {
+}): JSX.Element => {
   const tokenPrices = useAtomValue(
     tokenPricesFamily(asset?.address ? [asset.address] : [])
   );
@@ -446,7 +460,7 @@ const TransactionAmount: React.FC<{
   );
 };
 
-const BondUnbondTransactionCard: React.FC<Props> = ({ tx }) => {
+const BondUnbondTransactionCard = ({ tx }: Props): JSX.Element => {
   const { transaction, asset, transactionFailed, validators } =
     useTransactionCardData(tx);
   const txnInfo = getBondOrUnbondTransactionInfo(transaction);
@@ -495,7 +509,7 @@ const BondUnbondTransactionCard: React.FC<Props> = ({ tx }) => {
   );
 };
 
-const RedelegationTransactionCard: React.FC<Props> = ({ tx }) => {
+const RedelegationTransactionCard = ({ tx }: Props): JSX.Element => {
   const { transaction, asset, transactionFailed, validators } =
     useTransactionCardData(tx);
   const txnInfo = getRedelegationTransactionInfo(transaction);
@@ -564,7 +578,7 @@ const RedelegationTransactionCard: React.FC<Props> = ({ tx }) => {
   );
 };
 
-const VoteTransactionCard: React.FC<Props> = ({ tx }) => {
+const VoteTransactionCard = ({ tx }: Props): JSX.Element => {
   const { transaction, transactionFailed } = useTransactionCardData(tx);
   const voteInfo = getVoteTransactionInfo(transaction);
   const proposalId =
@@ -624,7 +638,7 @@ const VoteTransactionCard: React.FC<Props> = ({ tx }) => {
   );
 };
 
-const WithdrawTransactionCard: React.FC<Props> = ({ tx }) => {
+const WithdrawTransactionCard = ({ tx }: Props): JSX.Element => {
   const { transaction, transactionFailed, validators } =
     useTransactionCardData(tx);
 
@@ -664,7 +678,7 @@ const WithdrawTransactionCard: React.FC<Props> = ({ tx }) => {
   );
 };
 
-const GeneralTransactionCard: React.FC<Props> = ({ tx }) => {
+const GeneralTransactionCard = ({ tx }: Props): JSX.Element => {
   const { transaction, asset, transparentAddress, transactionFailed } =
     useTransactionCardData(tx);
   const txnInfo = getTransactionInfo(transaction, transparentAddress);

apps/namadillo/src/App/Transactions/TransactionHistory.tsx

@@ -81,26 +81,29 @@ export const TransactionHistory = (): JSX.Element => {
 
   const handleFiltering = (transaction: TransactionHistoryType): boolean => {
     const transactionKind = transaction.tx?.kind ?? "";
-    if (filter.toLowerCase() === "all") {
-      return transferKindOptions.includes(transactionKind);
-    } else if (filter === "received") {
-      return transaction.kind === "received";
-    } else if (filter === "redelegation") {
-      return transactionKind === "redelegation";
-    } else if (filter === "vote") {
-      return transactionKind === "voteProposal";
-    } else if (filter === "withdraw") {
-      return transactionKind === "withdraw";
-    } else if (filter === "transfer") {
-      return [
-        "transparentTransfer",
-        "shieldingTransfer",
-        "unshieldingTransfer",
-        "shieldedTransfer",
-      ].includes(transactionKind);
-    } else if (filter === "ibc") {
-      return transactionKind.startsWith("ibc");
-    } else return transactionKind === filter;
+    switch (filter.toLowerCase()) {
+      case "all":
+        return transferKindOptions.includes(transactionKind);
+      case "received":
+        return transaction.kind === "received";
+      case "redelegation":
+        return transactionKind === "redelegation";
+      case "vote":
+        return transactionKind === "voteProposal";
+      case "withdraw":
+        return transactionKind === "withdraw";
+      case "transfer":
+        return [
+          "transparentTransfer",
+          "shieldingTransfer",
+          "unshieldingTransfer",
+          "shieldedTransfer",
+        ].includes(transactionKind);
+      case "ibc":
+        return transactionKind.startsWith("ibc");
+      default:
+        return transactionKind === filter;
+    }
   };
 
   const filterDuplicateTransactions = (