Skip to content

motor testing can cause unintentional launch on later disarm. #5

@nmw

Description

@nmw

the "If (motors_running) enable test mode" part on your motor test page puts things in a dangerous state, because the MSP_SET_MOTOR currently in baseflight updates the disarmed motor speeds, which has no immediate effect (so adjusting them doesn't work in configurator anyway, until you disarm).

When you disarm, it jumps to whatever speeds were set using MSP_SET_MOTOR, which can happen even after leaving that screen and/or disconnecting.

I've made some fixes to baseflight, which mostly prevent this from happening, but as you currently need to disarm before doing motor testing anyway, it probably makes most sense to just remove that, or better yet, disallow checking the box when armed (to avoid the potential jump at disarm). Also setting values to minimum when checking the box is probably not a bad idea either.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions