Fix unit tests

Author: mudrd8mz

tests/message_providers_test.php

@@ -83,7 +83,7 @@ public function test_message_providers(): void {
 
         // Verify if the message provider has been generated correctly.
         $messageprovider = $recipe['message_providers'][0]['name'];
-        $this->assertStringContainsString("'".$messageprovider."' => array(", $messagesfile);
+        $this->assertStringContainsString("'".$messageprovider."' => [", $messagesfile);
 
         $capability = $recipe['message_providers'][0]['capability'];
         $this->assertStringContainsString("'capability' => '".$capability."'", $messagesfile);

tests/mobile_addons_test.php

@@ -86,17 +86,15 @@ public function test_db_mobile_php(): void {
         $moodleinternal = "defined('MOODLE_INTERNAL') || die()";
         $this->assertStringContainsString($moodleinternal, $dbmobilefile);
 
-        $addon = "'".$recipe['mobile_addons'][0]['name']."' => array(";
+        $addon = "'".$recipe['mobile_addons'][0]['name']."' => [";
         $this->assertStringContainsString($addon, $dbmobilefile);
 
         $dependencieslist = $recipe['mobile_addons'][0]['dependencies'];
-        foreach ($dependencieslist as $key => $dependency) {
-            $dependencieslist[$key] = "'".$dependency['name']."'";
+        foreach ($dependencieslist as $dependency) {
+            $this->assertStringContainsString("'".$dependency['name']."'", $dbmobilefile);
         }
-        $dependencies = "'dependencies' => array(".implode(', ', $dependencieslist).", )";
-        $this->assertStringContainsString($dependencies, $dbmobilefile);
 
-        $addon = "'".$recipe['mobile_addons'][1]['name']."' => array(";
+        $addon = "'".$recipe['mobile_addons'][1]['name']."' => [";
         $this->assertStringContainsString($addon, $dbmobilefile);
     }
 }

tests/mod_test.php

@@ -262,7 +262,7 @@ public function test_view_php(): void {
         $requirelogin = 'require_login($course, true, $cm)';
         $this->assertStringContainsString($requirelogin, $viewfile);
 
-        $seturl = "\$PAGE->set_url('/mod/demo/view.php', array('id' => \$cm->id))";
+        $seturl = "\$PAGE->set_url('/mod/demo/view.php', ['id' => \$cm->id])";
         $this->assertStringContainsString($seturl, $viewfile);
 
         $header = 'echo $OUTPUT->header()';
@@ -294,13 +294,13 @@ public function test_index_php(): void {
         $requireconfig = "require(__DIR__.'/../../config.php')";
         $this->assertStringContainsString($requireconfig, $indexfile);
 
-        $course = "\$DB->get_record('course', array('id' => \$id), '*', MUST_EXIST)";
+        $course = "\$DB->get_record('course', ['id' => \$id], '*', MUST_EXIST)";
         $this->assertStringContainsString($course, $indexfile);
 
         $requirecourselogin = 'require_course_login($course)';
         $this->assertStringContainsString($requirecourselogin, $indexfile);
 
-        $seturl = "\$PAGE->set_url('/mod/demo/index.php', array('id' => \$id))";
+        $seturl = "\$PAGE->set_url('/mod/demo/index.php', ['id' => \$id])";
         $this->assertStringContainsString($seturl, $indexfile);
 
         $header = 'echo $OUTPUT->header()';
@@ -383,7 +383,7 @@ public function test_file_area_feature(): void {
         $this->assertStringContainsString($getfileinfo, $libfile);
 
         $pluginfile = 'function demo_pluginfile('.
-            '$course, $cm, $context, $filearea, $args, $forcedownload, $options = array())';
+            '$course, $cm, $context, $filearea, $args, $forcedownload, $options = [])';
         $this->assertStringContainsString($pluginfile, $libfile);
     }
 

tests/privacy_test.php

@@ -107,7 +107,7 @@ public function test_null_provider(): void {
 
         $this->assertStringContainsString('Privacy API implementation for the Foo bar plugin.', $providerphp);
         $this->assertStringContainsString('class provider implements \core_privacy\local\metadata\null_provider {', $providerphp);
-        $this->assertStringContainsString('public static function get_reason() : string {', $providerphp);
+        $this->assertStringContainsString('public static function get_reason(): string {', $providerphp);
 
         $langfile = $files['lang/en/local_foobar.php'];
 
@@ -303,7 +303,7 @@ public function test_dbfields_metadata_provider(): void {
             $providerphp
         );
         $this->assertStringContainsString(
-            'public static function get_metadata(collection $collection) : collection {',
+            'public static function get_metadata(collection $collection): collection {',
             $providerphp
         );
     }
@@ -447,7 +447,7 @@ public function test_get_contexts_for_userid(): void {
 
         $this->assertStringContainsString('use core_privacy\local\request\contextlist;', $providerphp);
         $this->assertStringContainsString(
-            'public static function get_contexts_for_userid(int $userid) : contextlist {',
+            'public static function get_contexts_for_userid(int $userid): contextlist {',
             $providerphp
         );
     }

tests/tiny_test.php

@@ -141,7 +141,7 @@ protected static function get_test(array $settings = []): array {
      * @param array $settings
      * @return array
      */
-    protected function get_recipe(array $settings = []): array {
+    protected static function get_recipe(array $settings = []): array {
         $settings = array_merge([
             'options' => [],
             'buttons' => false,