Skip to content

Commit 6c5e0a1

Browse files
muchinyclaude
andcommitted
ci(release): drop windows-x86_64 from the release matrix
The Sprint 3 daemon mode uses tokio::net::UnixListener / UnixStream, which are Unix-only. Rather than gate the daemon subcommand + CLI fast-path behind #[cfg(unix)] and ship a Windows binary with a permanently-crippled surface, remove Windows from the release pipeline entirely: the bridge targets POSIX hosts where a real daemon can run and cache SSH connections across CLI invocations. Changes: - release.yml matrix: drop the `x86_64-pc-windows-msvc` / windows-latest entry. Now 4 targets: linux-x86_64, linux-arm64, macos-x86_64, macos-arm64. - Collapse `Package (unix)` and `Package (windows)` into a single `Package` step (all four remaining targets use tar.gz). - DXT packaging loop no longer tries to unzip a windows-x86_64 zip. The release job `needs: build` would silently skip on Windows build failures, so v1.12.0's first tag push produced no GitHub Release. Retagging after this fix. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent d092fea commit 6c5e0a1

1 file changed

Lines changed: 1 addition & 21 deletions

File tree

‎.github/workflows/release.yml‎

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,6 @@ jobs:
3939
os: macos-latest
4040
name: macos-arm64
4141
archive: tar.gz
42-
- target: x86_64-pc-windows-msvc
43-
os: windows-latest
44-
name: windows-x86_64
45-
archive: zip
4642

4743
steps:
4844
- uses: actions/checkout@v6
@@ -72,23 +68,13 @@ jobs:
7268
if: ${{ !matrix.cross }}
7369
run: cargo build --release --target ${{ matrix.target }}
7470

75-
- name: Package (unix)
76-
if: matrix.archive == 'tar.gz'
71+
- name: Package
7772
run: |
7873
cd target/${{ matrix.target }}/release
7974
tar czf ../../../${{ env.BINARY_NAME }}-${{ matrix.name }}.tar.gz ${{ env.BINARY_NAME }}
8075
cd ../../..
8176
sha256sum ${{ env.BINARY_NAME }}-${{ matrix.name }}.tar.gz > ${{ env.BINARY_NAME }}-${{ matrix.name }}.tar.gz.sha256
8277
83-
- name: Package (windows)
84-
if: matrix.archive == 'zip'
85-
shell: bash
86-
run: |
87-
cd target/${{ matrix.target }}/release
88-
7z a ../../../${{ env.BINARY_NAME }}-${{ matrix.name }}.zip ${{ env.BINARY_NAME }}.exe
89-
cd ../../..
90-
sha256sum ${{ env.BINARY_NAME }}-${{ matrix.name }}.zip > ${{ env.BINARY_NAME }}-${{ matrix.name }}.zip.sha256
91-
9278
- name: Upload artifact
9379
uses: actions/upload-artifact@v7
9480
with:
@@ -133,12 +119,6 @@ jobs:
133119
cd dist && zip -r "../artifacts/${{ env.BINARY_NAME }}-${arch}.dxt" dxt-${arch}/ && cd ..
134120
fi
135121
done
136-
mkdir -p dist/dxt-windows-x86_64
137-
if [ -f "artifacts/${{ env.BINARY_NAME }}-windows-x86_64.zip" ]; then
138-
unzip "artifacts/${{ env.BINARY_NAME }}-windows-x86_64.zip" -d dist/dxt-windows-x86_64/
139-
cp dxt/manifest.json dxt/icon.svg dist/dxt-windows-x86_64/
140-
cd dist && zip -r "../artifacts/${{ env.BINARY_NAME }}-windows-x86_64.dxt" dxt-windows-x86_64/ && cd ..
141-
fi
142122
143123
- name: Create GitHub Release
144124
uses: softprops/action-gh-release@v2

0 commit comments

Comments
 (0)