chore: cleanup features handling

Author: mshima

src/generator.ts

@@ -12,7 +12,7 @@ import createDebug from 'debug';
 import { type MemFsEditor, create as createMemFsEditor } from 'mem-fs-editor';
 import { type YeomanNamespace, requireNamespace, toNamespace } from '@yeoman/namespace';
 import type { BaseEnvironment, BaseGenerator as GeneratorApi, Logger, QueuedAdapter } from '@yeoman/types';
-import type { ArgumentSpec, BaseFeatures, BaseOptions, CliOptionSpec, Priority } from './types.js';
+import type { ArgumentSpec, BaseFeatures, BaseOptions, CliOptionSpec } from './types.js';
 import type { PromptAnswers, PromptQuestion, PromptQuestions, QuestionRegistrationOptions } from './questions.js';
 import Storage, { type StorageOptions } from './util/storage.js';
 import { prefillQuestions, storeAnswers } from './util/prompt-suggestion.js';
@@ -57,7 +57,6 @@ export class BaseGenerator<
 
   readonly _namespace: string;
   readonly _namespaceId?: YeomanNamespace;
-  readonly _customPriorities?: Priority[];
   readonly resolved: string;
   description: string;
   contextRoot!: string;
@@ -171,9 +170,6 @@ export class BaseGenerator<
     this._initOptions = { ...actualOptions };
     this._namespace = actualOptions.namespace;
     this._namespaceId = toNamespace(actualOptions.namespace);
-    this._customPriorities = this.#features?.customPriorities;
-    this.#features.skipParseOptions = this.#features.skipParseOptions ?? this.options.skipParseOptions;
-    this.#features.customPriorities = this.#features.customPriorities ?? this.options.customPriorities;
 
     this.option('help', {
       type: Boolean,

src/index.ts

@@ -29,8 +29,8 @@ export default class Generator<
     }
 
     // Add custom queues
-    if (Array.isArray(this._customPriorities)) {
-      this.registerPriorities(this._customPriorities);
+    if (Array.isArray(this.features.customPriorities)) {
+      this.registerPriorities(this.features.customPriorities);
     }
   }
 

src/types.d.ts

@@ -122,12 +122,6 @@ export type BaseOptions = OptionsApi & {
   skipLocalCache?: boolean;
 
   description?: string;
-
-  /** @deprecated moved to features */
-  skipParseOptions?: boolean;
-
-  /** @deprecated moved to features */
-  customPriorities?: Priority[];
 };
 
 export type ArgumentSpec = {

test/base.test.ts

@@ -1884,7 +1884,7 @@ describe('Base', () => {
     });
   });
 
-  describe('#getFeatures', () => {
+  describe('#features', () => {
     it('should return namespace as uniqueBy when unique is true', () => {
       const gen = new Base([], { namespace: 'foo', env }, { unique: true });
       assert.equal(gen.features.uniqueBy, 'foo');