Skip to content

Commit a73ba9e

Browse files
committed
fix: rename override to replacement
1 parent b772172 commit a73ba9e

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

src/generator.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -826,7 +826,7 @@ export class BaseGenerator<O extends BaseOptions = BaseOptions, F extends BaseFe
826826
*/
827827
getContextData<const T = any>(
828828
context: string | { context: string; key: string },
829-
opts: { override?: T } | { factory?: () => T } = {},
829+
opts: { replacement?: T } | { override?: T } | { factory?: () => T } = {},
830830
): T {
831831
if (!('getContextMap' in this.env)) {
832832
throw new Error('getContextMap is not implemented in the environment');
@@ -837,6 +837,10 @@ export class BaseGenerator<O extends BaseOptions = BaseOptions, F extends BaseFe
837837
typeof context === 'object' ? (this.env as any).getContextMap(context.context) : this._contextMap;
838838

839839
const value = map.get(key);
840+
if ('replacement' in opts) {
841+
map.set(key, opts.replacement);
842+
return value;
843+
}
840844
if ('override' in opts) {
841845
map.set(key, opts.override);
842846
return value;

test/generators.test.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -156,19 +156,19 @@ describe('Generators module', () => {
156156
expect(env.getContextMap(context).get(key)).toBe(data);
157157
});
158158

159-
it('using overrides option sets new data and retrieves old data', () => {
159+
it('using replacement option sets new data and retrieves old data', () => {
160160
const key = 'foo';
161161
const data = 'bar';
162-
expect(generator.getContextData(key, { override: data })).toBe(undefined);
163-
expect(generator.getContextData(key, { override: 'new' })).toBe(data);
162+
expect(generator.getContextData(key, { replacement: data })).toBe(undefined);
163+
expect(generator.getContextData(key, { replacement: 'new' })).toBe(data);
164164
});
165165

166-
it('supports overrides option with custon context', () => {
166+
it('supports replacement option with custon context', () => {
167167
const context = 'ctx';
168168
const key = 'foo';
169169
const data = 'bar';
170-
expect(generator.getContextData({ context, key }, { override: data })).toBe(undefined);
171-
expect(generator.getContextData({ context, key }, { override: 'new' })).toBe(data);
170+
expect(generator.getContextData({ context, key }, { replacement: data })).toBe(undefined);
171+
expect(generator.getContextData({ context, key }, { replacement: 'new' })).toBe(data);
172172
expect(env.getContextMap(context).get(key)).toBe('new');
173173
});
174174
});

0 commit comments

Comments
 (0)