Skip to content

Commit 03e165b

Browse files
authored
Merge pull request #24 from mpchadwick/release/v0.5.0
Release v0.5.0 -> Master
2 parents ab6a293 + 208c0ac commit 03e165b

File tree

5 files changed

+25
-4
lines changed

5 files changed

+25
-4
lines changed

app/code/community/Mpchadwick/PageCacheHitRate/Model/Observer.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ public function handleControllerFrontSendResponseBefore(Varien_Event_Observer $o
3535
// Track any container misses for a partial cache response
3636
$trackContainerMisses = (string)$config->get('track_container_misses');
3737
if ($type === 'partial' && $trackContainerMisses) {
38-
unset($params['type']);
3938
$tracker->trackContainerMisses($params);
4039
}
4140
}

app/code/community/Mpchadwick/PageCacheHitRate/Model/Tracker/Abstract.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@ public function track($type, array $args, $alias)
2929

3030
public function trackContainerMisses($params)
3131
{
32+
unset($params['type']);
3233
$containers = Mage::registry('cached_page_containers');
3334

3435
foreach ($containers as $container) {

app/code/community/Mpchadwick/PageCacheHitRate/Model/Tracker/ParamProvider.php

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,34 @@
22

33
class Mpchadwick_PageCacheHitRate_Model_Tracker_ParamProvider
44
{
5+
// Taken from Cm_RedisSession_Model_Session
6+
const BOT_REGEX = '/^alexa|^blitz\.io|bot|^browsermob|crawl|^curl|^facebookexternalhit|feed|google web preview|^ia_archiver|^java|jakarta|^load impact|^magespeedtest|monitor|nagios|^pinterest|postrank|slurp|spider|uptime|yandex/i';
7+
8+
protected $userAgent;
9+
10+
protected $isBot;
11+
12+
public function __construct()
13+
{
14+
$this->userAgent = empty($_SERVER['HTTP_USER_AGENT']) ? '' : $_SERVER['HTTP_USER_AGENT'];
15+
if ($this->userAgent) {
16+
$this->isBot = preg_match(self::BOT_REGEX, $this->userAgent);
17+
} else {
18+
// Can't be sure, but let's say it's not a bot...
19+
$this->isBot = 0;
20+
}
21+
22+
}
23+
524
public function baseParams($originalRequest = false)
625
{
726
return array(
827
'url' => $this->getUrl($originalRequest),
928
'ip' => Mage::app()->getRequest()->getClientIp(),
1029
'hostname' => gethostname(),
1130
'customerGroup' => $this->getCustomerGroup(),
31+
'userAgent' => $this->userAgent,
32+
'isBot' => $this->isBot,
1233
);
1334
}
1435

app/code/community/Mpchadwick/PageCacheHitRate/Model/Tracker/Redis.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@ class Mpchadwick_PageCacheHitRate_Model_Tracker_Redis
99
/** @var Credis_Client */
1010
protected $redis;
1111

12-
public function connection()
12+
public function connection($alias)
1313
{
14-
$this->setupConnection();
14+
$this->setupConnection($alias);
1515
return $this->redis;
1616
}
1717

app/code/community/Mpchadwick/PageCacheHitRate/etc/config.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<config>
33
<modules>
44
<Mpchadwick_PageCacheHitRate>
5-
<version>0.4.0</version>
5+
<version>0.5.0</version>
66
</Mpchadwick_PageCacheHitRate>
77
</modules>
88
<global>

0 commit comments

Comments
 (0)