lint stage is missing at local dev environment

[chfw]

it is agreeable that in travis, linting stage should be different from unit test stage. However, lint stage was removed from local unit test process, which I think it is a flaw in overall quality control process. the developer shall know flake8 issues before checking their code in.

So the solution could be, to add git pre commit hook so that at least, his/her code were checked before a round trip to travis and finding the same thing.

[jayvdb]

What was removed ?

[chfw]

well, long story short: linting used to be part of each unit test run. As a part of lint stage separation, we remove it from unit test process, which made sense at the time.

now, because linting is not part of each unit test run, I got the lint feedback from travis. Taking the inspiration from(moremoban/moban#290), pre commit hook is probably better than getting lint-check back to be a part of unit test process.

[jayvdb]

Sorry, I am specifically asking what change in this repository "removed" something.

pre-commit hooks are a per-user decision, not per-repo. https://pre-commit.com/ , or similar, can help.

pytest can also run flake8 -- there are pytest plugins for most common linters. They can be activated in setup.cfg, pytest.ini, etc

[chfw]

the refinement version 1 happened here: 1650163

It seems that I "married" with nose tool, so pytest is bit distant to me. And because of my bias, pypi-mobans is also biased towards nose and could be strange to pytest users.

[jayvdb]

Ah, I see.

Well those files are all primarily pyexcel templates so feel free to abuse them however you want.

This repo uses some of them, but IMO it shouldnt, as the common practise is to use pytest, so the templates should all default to that. (but supporting nose and other test runners is important)