Skip to content

Conversation

@lameze
Copy link
Contributor

@lameze lameze commented Mar 14, 2025

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.75%. Comparing base (34a9d6b) to head (cd00519).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
+ Coverage   29.70%   31.75%   +2.04%     
==========================================
  Files          71       71              
  Lines        3222     3222              
==========================================
+ Hits          957     1023      +66     
+ Misses       2265     2199      -66     
Flag Coverage Δ
check_upgrade_savepoints 0.46% <ø> (ø)
checkstyle_manipulations 0.00% <ø> (ø)
compare_databases 2.38% <ø> (ø)
continuous_manage_queues_validation 0.71% <ø> (ø)
define_excluded 1.11% <ø> (ø)
detect_conflicts 1.48% <ø> (ø)
diff_extract_changes 0.00% <ø> (ø)
git_sync_two_branches 2.04% <ø> (?)
grunt_process 3.01% <ø> (ø)
illegal_whitespace 2.63% <ø> (ø)
list_valid_components 0.00% <ø> (ø)
mustache_lint 2.82% <ø> (ø)
mustache_lint_plugins 1.30% <ø> (ø)
php_lint 1.21% <ø> (ø)
prepare_npm_stuff 1.52% <ø> (ø)
remote_branch_checker 17.38% <ø> (ø)
remote_branch_reporter 0.00% <ø> (ø)
setup 0.00% <ø> (ø)
thirdparty_check 1.45% <ø> (ø)
travis-branch-checker 0.00% <ø> (ø)
upgrade_external_backup 1.61% <ø> (ø)
verifications 0.00% <ø> (ø)
verify_commit_messages 2.63% <ø> (ø)
versions_check_set 5.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@sarjona sarjona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lameze!
Thanks for working on this. The patch looks good and I've been able to confirm that the failing GH actions are consistently failing in the main branch too (without this patch), so I think it's ok to fix them in a separate issue.
I'm happy to approve this.

Should I also merge it or is that anything that you'll do? :-)

@HuongNV13
Copy link
Contributor

Thanks, Simey, for working on this one.
The patch looks right to me. The failures seem unrelated so I think we can address them later.

@HuongNV13 HuongNV13 merged commit 86ee115 into main Mar 17, 2025
97 of 103 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants