Correctly quote jira filters

Author: andrewnicols

tracker_automations/component_leads_integration_mover/component_leads_integration_mover.sh

@@ -114,7 +114,7 @@ fi
 
 # Search for all the issues awaiting for integration and not being decided between CLR/IR.
 ${basereq} --action getIssueList \
-           --jql "filter = ${filter_integrationCLRDecision} ${excludequery}" \
+           --jql "filter = '${filter_integrationCLRDecision}' ${excludequery}" \
            --columns="Key,Assignee,Peer reviewer,Components,Security Level,Summary" \
            --outputFormat=4 \
            --outputType=json \

tracker_automations/continuous_manage_queues/lib.sh

@@ -30,9 +30,9 @@ function run_A1() {
 
     # Get the list of issues.
     ${basereq} --action getIssueList \
-               --jql "(filter=${filter_candidatesForIntegration}) \
+               --jql "(filter='${filter_candidatesForIntegration}') \
                      AND type IN ('New Feature', Improvement) \
-                     AND NOT filter = ${filter_issuesVotedToUnhold} \
+                     AND NOT filter = '${filter_issuesVotedToUnhold}' \
                      AND NOT (status changed FROM 'Waiting for component lead review' TO 'Waiting for integration review' AFTER -2h)" \
                --file "${resultfile}"
 
@@ -63,10 +63,10 @@ If you want Moodle HQ to consider including it into the incoming major release p
 function run_A2() {
     # Get the list of issues.
     ${basereq} --action getIssueList \
-               --jql "filter=${filter_candidatesForIntegration}
-                     AND NOT filter = ${filter_issuesHeldUntilAfterRelease}
+               --jql "filter='${filter_candidatesForIntegration}'
+                     AND NOT filter = '${filter_issuesHeldUntilAfterRelease}'
                      AND (
-                       filter = ${filter_mustFixIssues} OR
+                       filter = '${filter_mustFixIssues}' OR
                        labels IN (mdlqa) OR
                        level IS NOT EMPTY
                      )" \
@@ -134,7 +134,7 @@ function run_A3a() {
     if [[ "$counter" -lt "$currentmin" ]]; then
         # Get an ordered list of issues in the candidate queue.
         ${basereq} --action getIssueList \
-                   --jql "filter=${filter_candidatesForIntegration} \
+                   --jql "filter='${filter_candidatesForIntegration}' \
                        ORDER BY Rank ASC" \
                    --file "${resultfile}"
 
@@ -194,9 +194,9 @@ function run_A3b() {
     # - Must-fix issues
     # - mdlqa issues
     ${basereq} --action getIssueList \
-               --jql "filter=${filter_candidatesForIntegration} OR (
-                      filter=${filter_candidatesForCLR} AND NOT (
-                        filter = ${filter_mustFixIssues} OR
+               --jql "filter='${filter_candidatesForIntegration}' OR (
+                      filter='${filter_candidatesForCLR}' AND NOT (
+                        filter = '${filter_mustFixIssues}' OR
                         labels IN (mdlqa)
                       )
                     )" \
@@ -242,7 +242,7 @@ function run_B1b() {
     if [[ "$counter" -lt "$currentmin" ]]; then
         # Get an ordered list of issues in the candidate queue.
         ${basereq} --action getIssueList \
-                   --jql "filter=${filter_candidatesForIntegration} \
+                   --jql "filter='${filter_candidatesForIntegration}' \
                        ORDER BY Rank ASC" \
                    --file "${resultfile}"
 
@@ -305,9 +305,9 @@ function run_B1a() {
 
     # Get the list of issues.
     ${basereq} --action getIssueList \
-               --jql "(filter=${filter_candidatesForIntegration} OR filter=${filter_candidatesForCLR}) \
+               --jql "(filter='${filter_candidatesForIntegration}' OR filter='${filter_candidatesForCLR}') \
                      AND type IN ('New Feature', Improvement) \
-                     AND NOT filter = ${filter_issuesVotedToUnhold}" \
+                     AND NOT filter = '${filter_issuesVotedToUnhold}'" \
                --file "${resultfile}"
 
     # Iterate over found issues and perform the actions with them.

tracker_automations/normal_manage_queues/lib.sh

@@ -23,10 +23,10 @@ source "${mydir}/../../jira.sh"
 function run_A() {
     # Get the list of issues.
     ${basereq} --action getIssueList \
-               --jql "filter=${filter_candidatesForIntegration}
-                     AND NOT filter = ${filter_issuesHeldUntilAfterRelease}
+               --jql "filter='${filter_candidatesForIntegration}'
+                     AND NOT filter = '${filter_issuesHeldUntilAfterRelease}'
                      AND (
-                       filter = ${filter_mustFixIssues} OR
+                       filter = '${filter_mustFixIssues}' OR
                        labels IN (mdlqa) OR
                        priority IN (Critical, Blocker) OR
                        level IS NOT EMPTY OR
@@ -96,7 +96,7 @@ function run_B() {
     if [[ "$counter" -lt "$currentmin" ]]; then
         # Get an ordered list of up to issues in the candidate queue.
         ${basereq} --action getIssueList \
-                   --jql "filter=${filter_candidatesForIntegration} \
+                   --jql "filter='${filter_candidatesForIntegration}' \
                        ORDER BY Rank ASC" \
                    --file "${resultfile}"
 
@@ -152,7 +152,7 @@ function run_B() {
 function run_C() {
     # Get the list of issues.
     ${basereq} --action getIssueList \
-               --jql "filter=${filter_candidatesForIntegration}
+               --jql "filter='${filter_candidatesForIntegration}'
                      AND 'Integration priority' = 0
                      AND NOT (issueLinkType = 'blocks' OR issueLinkType = 'is blocked by')
                      AND NOT status CHANGED AFTER -${waitingdays}d" \

tracker_automations/send_rebase_message/send_rebase_message.sh

@@ -53,7 +53,7 @@ fi
 
 # Let's search all the issues under candidates queue.
 ${basereq} --action getIssueList \
-           --jql "filter = ${filter_candidatesForIntegration}" \
+           --jql "filter = '${filter_candidatesForIntegration}'" \
            --file "${resultfile}"
 
 # Iterate over found issues and perform the actions with them
@@ -75,7 +75,7 @@ TIA and ciao :-)"}
 
 # Let's search all the issues under current integration waiting for review or in progress.
 ${basereq} --action getIssueList \
-           --jql "filter = ${filter_issuesWaitingForReviewOrInProgress}" \
+           --jql "filter = '${filter_issuesWaitingForReviewOrInProgress}'" \
            --file "${resultfile}"
 
 # Iterate over found issues and perform the actions with them.