Elg.cs : EGL_EXPERIMENTAL_PRESENT_PATH_FAST_ANGLE value incorrect

[JPDelprat]

Description

Elg.cs : EGL_EXPERIMENTAL_PRESENT_PATH_FAST_ANGLE value incorrect

=> correct value is 0x33A9
=> current value in code is 0x33AA => NOK

Code

Version 3.0.119.

Elg.cs : EGL_EXPERIMENTAL_PRESENT_PATH_FAST_ANGLE value incorrect

=> correct value is 0x33A9
=> current value in code is 0x33AA => NOK

Expected Behavior

No response

Actual Behavior

No response

Version of SkiaSharp

Other (Please indicate in the description)

Last Known Good Version of SkiaSharp

2.88.9 (Previous)

IDE / Editor

Visual Studio (Windows)

Platform / Operating System

Other (Please indicate in the description)

Platform / Operating System Version

No response

Devices

No response

Relevant Screenshots

No response

Relevant Log Output

Code of Conduct

• I agree to follow this project's Code of Conduct

[molesmoke]

That's a good spot! It was also the wrong value in 2.88.9 though...

I was using that in my own custom control before the DX12 backend was enabled. IIRC, part of the perf improvement is that it's not conformant (the surfaces are vertically flipped). So, if the fast path were enabled, then users creating surfaces from SKSwapChainPanel.GRContext would find that they need to swap the surface origin to GRSurfaceOrigin.TopLeft. Surprisingly, SKSwapChainPanel seems to still render the right way up for its paint event, so the fallout might not be too bad.

@mattleibow Might want to comment on whether he'd prefer a fix that explicitly uses the copy path, or whether the fast path should be correctly enabled as a breaking change?