SQLForeignKeys() crashing when SQL_MODE='ANSI_QUOTES' (Bug# 18641824), SQLForeignKeys() returns empty result with NO_I_S=0 (Bug# 26388694)

Author: Bogdan Degtyariov

ChangeLog

@@ -10,8 +10,12 @@
     (Bug# 18805392)
   * SQLExecute() after SQLFreeStmt(SQL_RESET_PARAMS) results
     in assert failure (Bug# 19148246)
+  * SQLForeignKeys() crashing when SQL_MODE='ANSI_QUOTES'
+    (Bug# 18641824)
+  * SQLForeignKeys() returns empty result with NO_I_S=0
+    (Bug# 26388694)
 
-  Built using MySQL 5.
+  Built using MySQL 5.7.19
 
 ----
 

driver/catalog.c

@@ -907,7 +907,7 @@ SQLRETURN foreign_keys_i_s(SQLHSTMT hstmt,
                 " ON (D.TABLE_SCHEMA=A.REFERENCED_TABLE_SCHEMA AND D.TABLE_NAME=A.REFERENCED_TABLE_NAME"
                     " AND D.COLUMN_NAME=A.REFERENCED_COLUMN_NAME)",
                 ref_constraints_join,
-                " WHERE D.CONSTRAINT_NAME='PRIMARY' ",
+                " WHERE D.CONSTRAINT_NAME IS NOT NULL ",
                 NullS);
 
   if (pk_table_name && pk_table_name[0])

driver/utility.c

@@ -4041,8 +4041,12 @@ const char get_identifier_quote(STMT *stmt)
       The full list of all SQL modes takes over 512 symbols, so we reserve
       some for the future
      */
-    char sql_mode[2048]= {0};
-    uint length= get_session_variable(stmt, "SQL_MODE", (char*)sql_mode);
+    char sql_mode[2048]= " ";
+    /*
+      The token finder skips the leading space and starts
+      with the first non-space value. Thus (sql_mode+1).
+    */
+    uint length= get_session_variable(stmt, "SQL_MODE", (char*)(sql_mode+1));
 
     const char *end=  sql_mode + length;
     if (find_first_token(stmt->dbc->ansi_charset_info, sql_mode, end, "ANSI_QUOTES"))

test/my_crash.c

@@ -25,6 +25,59 @@
 #include "odbctap.h"
 #include "../VersionInfo.h"
 
+/*
+  18641824 SQLFOREIGNKEYS() CRASHING WHEN SQL_MODE='ANSI_QUOTES'
+  26388694 SQLForeignKeys() returns empty result with NO_I_S=0
+  
+  This test case will run with NO_I_S=0 and NO_I_S=1 and test for
+  two bugs for each NO_I_S value
+*/
+DECLARE_TEST(t_bug18641824)
+{
+  int i = 0;
+  char *pk_tab = "tab_pk";
+  char *fk_tab = "tab_fk";
+  char *pk_cols[] = { "i1d", "i2d" };
+  char *fk_cols[] = { "fi1d", "fi2d" };
+
+  DECLARE_BASIC_HANDLES(henv1, hdbc1, hstmt1);
+  is(OK == alloc_basic_handles(&henv1, &hdbc1, &hstmt1));
+
+  ok_sql(hstmt1, "set SQL_MODE='ANSI_QUOTES'");
+  ok_sql(hstmt1, "DROP SCHEMA IF EXISTS fk_check");
+  ok_sql(hstmt1, "CREATE SCHEMA fk_check");
+  ok_sql(hstmt1, "USE fk_check");
+  ok_sql(hstmt1, "CREATE TABLE tab_pk (i1d int, unique(i1d), i2d int, unique (i2d))");
+  ok_sql(hstmt1, "CREATE TABLE tab_fk (" \
+                "fi1d int,CONSTRAINT Constraint_1 FOREIGN KEY(fi1d) REFERENCES tab_pk(i1d)," \
+                "fi2d int,CONSTRAINT Constraint_2 FOREIGN KEY(fi2d) REFERENCES tab_pk(i2d))");
+  ok_stmt(hstmt1, SQLForeignKeys(hstmt1, NULL, 0, NULL, 0, (SQLCHAR*)"tab_pk", SQL_NTS,
+                                NULL, 0, NULL, 0, (SQLCHAR*)"tab_fk", SQL_NTS));
+
+  while (SQLFetch(hstmt1) == SQL_SUCCESS)
+  {
+    char buf[1024];
+    printf("Row: %d\n", ++i);
+    ok_stmt(hstmt1, SQLGetData(hstmt1, 3, SQL_CHAR, buf, sizeof(buf), NULL));
+    printf("Primary key table: %s\n", buf);
+    is_str(pk_tab, buf, strlen(buf));
+
+    ok_stmt(hstmt1, SQLGetData(hstmt1, 4, SQL_CHAR, buf, sizeof(buf), NULL));
+    printf("Primary key column: %s\n", buf);
+    is(strcmp(pk_cols[0], buf) == 0 || strcmp(pk_cols[1], buf) == 0);
+
+    ok_stmt(hstmt1, SQLGetData(hstmt1, 7, SQL_CHAR, buf, sizeof(buf), NULL));
+    printf("Foreign key table: %s\n", buf);
+    is_str(fk_tab, buf, strlen(buf));
+
+    ok_stmt(hstmt1, SQLGetData(hstmt1, 8, SQL_CHAR, buf, sizeof(buf), NULL));
+    printf("Foreign key column: %s\n", buf);
+    is(strcmp(fk_cols[0], buf) == 0 || strcmp(fk_cols[1], buf) == 0);
+  }
+  is(i==2);
+  free_basic_handles(&henv1, &hdbc1, &hstmt1);
+  return OK;
+}
 
 /*
   18805392 SEGMENTATION FAULT IN SQLFETCH() WHEN USED WITH DYNAMIC CURSOR
@@ -40,9 +93,9 @@ DECLARE_TEST(t_bug18805392)
 
   ok_stmt(hstmt1, SQLSetStmtAttr(hstmt1, SQL_ATTR_CURSOR_TYPE,
                                  (SQLPOINTER)SQL_CURSOR_DYNAMIC, 0));
-  ok_sql(hstmt, "DROP TABLE IF EXISTS t_bug18805392");
-  ok_sql(hstmt, "CREATE TABLE t_bug18805392 (record bigint)");
-  ok_sql(hstmt, "INSERT INTO t_bug18805392 VALUES (1234567891234),"
+  ok_sql(hstmt1, "DROP TABLE IF EXISTS t_bug18805392");
+  ok_sql(hstmt1, "CREATE TABLE t_bug18805392 (record bigint)");
+  ok_sql(hstmt1, "INSERT INTO t_bug18805392 VALUES (1234567891234),"
 								"(51234567891234),(61234567891234),(56789453632)");
 
   ok_stmt(hstmt1, SQLPrepare(hstmt1, (SQLCHAR *)"SELECT * FROM t_bug18805392 where record>?", SQL_NTS));
@@ -628,7 +681,7 @@ DECLARE_TEST(t_bug18286366)
     is_str(my_fetch_str(hstmt1, buff, 12), tmp_buff, len);
   }
 
-  ok_sql(hstmt, "DROP TABLE IF EXISTS t_bug16920750b, t_bug16920750a");
+  ok_sql(hstmt, "DROP TABLE IF EXISTS t_bug18286366b, t_bug18286366a");
   free_basic_handles(&henv1, &hdbc1, &hstmt1);
   return OK;
 }
@@ -889,7 +942,8 @@ DECLARE_TEST(t_bug18796005)
 
 
 BEGIN_TESTS
-  //ADD_TEST(t_bug18805392)
+  ADD_TEST(t_bug18641824)
+  ADD_TEST(t_bug18805392)
   ADD_TEST(t_bug19148246)
   ADD_TEST(t_bug69950)
   ADD_TEST(t_bug70642)

test/my_keys.c

@@ -438,16 +438,20 @@ DECLARE_TEST(t_bug16920750)
   SQLCHAR buff[255];
   SQLLEN len;
 
+  ok_sql(hstmt, "DROP SCHEMA IF EXISTS fk_test");
+  ok_sql(hstmt, "CREATE SCHEMA fk_test");
+  ok_sql(hstmt, "USE fk_test");
+
   ok_sql(hstmt, "DROP TABLE IF EXISTS t_bug16920750c, t_bug16920750b, t_bug16920750a");
   ok_sql(hstmt, "CREATE TABLE t_bug16920750a (category INT NOT NULL, id INT NOT NULL, price DECIMAL, "
                 "PRIMARY KEY(category, id) ) ENGINE=INNODB;");
   ok_sql(hstmt, "CREATE TABLE t_bug16920750b (id INT NOT NULL, PRIMARY KEY (id)) ENGINE=InnoDB");
   ok_sql(hstmt, "CREATE TABLE t_bug16920750c (no INT NOT NULL AUTO_INCREMENT, product_category "
                 "INT NOT NULL, product_id INT NOT NULL, customer_id INT NOT NULL, "
                 "PRIMARY KEY(no), INDEX (product_category, product_id), INDEX (customer_id), "
-                "CONSTRAINT `constraint_1` FOREIGN KEY (product_category, product_id) "
+                "CONSTRAINT `constraint__1` FOREIGN KEY (product_category, product_id) "
                 "REFERENCES t_bug16920750a(category, id) ON UPDATE CASCADE ON DELETE RESTRICT, "
-                "CONSTRAINT `constraint_2` FOREIGN KEY (customer_id) "
+                "CONSTRAINT `constraint__2` FOREIGN KEY (customer_id) "
                 "REFERENCES t_bug16920750b(id) ) ENGINE=InnoDB");
 
   ok_stmt(hstmt, SQLForeignKeys(hstmt, NULL, 0, NULL, 0, NULL, 0, NULL, 0,
@@ -458,7 +462,7 @@ DECLARE_TEST(t_bug16920750)
   is_str(my_fetch_str(hstmt, buff, 4), "category", 8);
   is_str(my_fetch_str(hstmt, buff, 7), "t_bug16920750c", 14);
   is_str(my_fetch_str(hstmt, buff, 8), "product_category", 16);
-  is_str(my_fetch_str(hstmt, buff, 12), "constraint_1", 12);
+  is_str(my_fetch_str(hstmt, buff, 12), "constraint__1", 12);
   is_str(my_fetch_str(hstmt, buff, 10), "0", 1);
   is_str(my_fetch_str(hstmt, buff, 11), "3", 1);
 
@@ -467,7 +471,7 @@ DECLARE_TEST(t_bug16920750)
   is_str(my_fetch_str(hstmt, buff, 4), "id", 2);
   is_str(my_fetch_str(hstmt, buff, 7), "t_bug16920750c", 14);
   is_str(my_fetch_str(hstmt, buff, 8), "customer_id", 11);
-  is_str(my_fetch_str(hstmt, buff, 12), "constraint_2", 12);
+  is_str(my_fetch_str(hstmt, buff, 12), "constraint__2", 12);
   is_str(my_fetch_str(hstmt, buff, 10), "3", 1);
   is_str(my_fetch_str(hstmt, buff, 11), "3", 1);
 
@@ -476,7 +480,7 @@ DECLARE_TEST(t_bug16920750)
   is_str(my_fetch_str(hstmt, buff, 4), "id", 2);
   is_str(my_fetch_str(hstmt, buff, 7), "t_bug16920750c", 14);
   is_str(my_fetch_str(hstmt, buff, 8), "product_id", 10);
-  is_str(my_fetch_str(hstmt, buff, 12), "constraint_1", 12);
+  is_str(my_fetch_str(hstmt, buff, 12), "constraint__1", 12);
   is_str(my_fetch_str(hstmt, buff, 10), "0", 1);
   is_str(my_fetch_str(hstmt, buff, 11), "3", 1);