feat(data-modeling): add note editing to collections and relationships COMPASS-9654 #7171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
added
the
feature flagged
gribnoysup
force-pushed
the
COMPASS-9654
branch
from
460325b to
c684d25
Compare
gribnoysup
commented
Aug 7, 2025
There was a problem hiding this comment.
I'm moving all shared components here because otherwise we're still having slightly variable margings in sections, it's easier to control when this stuff is all coming from one place and the layout hierarchy is accounted for
gribnoysup
commented
Aug 7, 2025
| @@ -0,0 +1,26 @@ | |||
| import { useState, useLayoutEffect } from 'react'; | |||
|
|
|||
| export function useChangeOnBlur( | |||
There was a problem hiding this comment.
@Anemy depending on which PR lands first, I think you might want to either copy this over or update your branch to use it
paula-stacho
approved these changes
Aug 7, 2025
|
Good point, let me extend those! |
|
Units are passing and last commit didn't really changed anything else much, so I'll merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds note editing to collections and relationships