Skip to content

Conversation

@woodser
Copy link
Contributor

@woodser woodser commented Oct 12, 2025

wallet2 already provides getters for connection information, like the daemon address and login credentials.

This PR just adds a getter for the daemon proxy URI, so it can be collected by clients too.

@nahuhh
Copy link
Contributor

nahuhh commented Oct 12, 2025

Those other items (login info, address) are things that the caller already knows. The proxy is not.

i'm not sure its a good idea to expose the proxy to users, unless its only available to the unrestricted rpc

edit.. this is for the wallet, so nvm.
edit again: is this for the daemon proxy, or the wallet proxy?

@woodser
Copy link
Contributor Author

woodser commented Nov 24, 2025

is this for the daemon proxy, or the wallet proxy?

@nahuhh

This is the wallet's proxy to its daemon.

Without this, it's not possible for a client to collect the wallet's full daemon connection information after it's set.

This accessor is merely consistent with the other available accessors, to get the wallet daemon's address and login info, allowing a client to query this information as needed.

An example use case (already used in Haveno here), is that listeners can know if the global daemon connection has changed from each wallet's daemon connection, including the proxy configuration, in order to update each wallet's daemon connection accordingly.

Without this, each wallet would have to cache and maintain this information locally. It makes sense instead that there is a consistent accessor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants