Merge pull request #10123

tobtoht · tobtoht · commit 6bb36309d69e · 2025-10-27T18:52:36.000Z
4e9d199 daemon: fix print_cn command when 0 connections (jeffro256)
diff --git a/src/daemon/rpc_command_executor.cpp b/src/daemon/rpc_command_executor.cpp
@@ -644,12 +644,9 @@ bool t_rpc_command_executor::print_connections() {
     }
   }
 
-  auto longest_host = *std::max_element(res.connections.begin(), res.connections.end(),
-                                        [](const auto &info1, const auto &info2)
-                                        {
-                                          return info1.address.length() < info2.address.length();
-                                        });
-  int host_field_width = std::max(15, 8 + (int) longest_host.address.length());
+  int host_field_width = 15;
+  for (const auto &conn : res.connections)
+    host_field_width = std::max(host_field_width, 8 + (int) conn.address.length());
 
   tools::msg_writer() << std::setw(host_field_width) << std::left << "Remote Host"
       << std::setw(8) << "Type"

Original file line number	Diff line number	Diff line change
`@@ -644,12 +644,9 @@ bool t_rpc_command_executor::print_connections() {`
`644`	`644`	`}`
`645`	`645`	`}`
`646`	`646`
`647`		`- auto longest_host = *std::max_element(res.connections.begin(), res.connections.end(),`
`648`		`- [](const auto &info1, const auto &info2)`
`649`		`- {`
`650`		`- return info1.address.length() < info2.address.length();`
`651`		`- });`
`652`		`- int host_field_width = std::max(15, 8 + (int) longest_host.address.length());`
	`647`	`+ int host_field_width = 15;`
	`648`	`+ for (const auto &conn : res.connections)`
	`649`	`+ host_field_width = std::max(host_field_width, 8 + (int) conn.address.length());`
`653`	`650`
`654`	`651`	`tools::msg_writer() << std::setw(host_field_width) << std::left << "Remote Host"`
`655`	`652`	`<< std::setw(8) << "Type"`