various missing includes

[diggit]

Hi,
I have stumbled on multiple missing includes.

1. STM32 USB header
   https://github.com/modm-io/modm/blob/7badc7de80945518867c051fcbd8295677c46aeb/src/modm/platform/usb/stm32/usb.hpp.in

is calling RCC functions, but it is missing RCC include

#include <modm/platform/clock/rcc.hpp>

Also there is a literal _MHz in the static assert used, thus #include <modm/math/units.hpp> is also missing (and using namespace modm::literals;)

2. iostream_chrono.hpp
   https://github.com/modm-io/modm/blob/develop/src/modm/io/iostream_chrono.hpp.in

uses IOStream functions but does not include proper header
#include <modm/io/iostream.hpp>

[salkinium]

Thanks, please open a PR so I can review these fixes directly.

[salkinium]

For point 2, the header is included by iostream.hpp itself, therefore does not include iostream.hpp.

modm/src/modm/io/iostream.hpp.in

Line 374 in 7badc7d

#include "iostream_chrono.hpp"

[diggit]

Thanks, please open a PR so I can review these fixes directly.

Will do! Though it may take a while as I will off for a week.

For point 2, the header is included by iostream.hpp itself, therefore does not include iostream.hpp.

I see, but I consider this bad design choice (sorry), as looking into iostream_chrono.hpp make tools like linker confused.
Included file should not depend on the core, by which it is included.

These 2 options come to my mind, maybe there are more...

1. move contents of iostream.hpp into separate file, this one could be included by iostream_chrono.hpp and then include both by iostream.hpp
2. mergeiostream.hpp and iostream_chrono.hpp, but I suppose, there is a reason why those are split.

[salkinium]

Yeah, good point. You can add the include at the top to help the IDE/tooling, it won't hurt the compiler.