Skip to content

Update and rename airr_official_1.0_practice_prompt_set_release_publi… - #22

Merged
mikek-mlcommons merged 1 commit into
mainfrom
mikek-mlcommons-patch-4
Mar 17, 2025
Merged

mikek-mlcommons merged 1 commit into
mainfrom
mikek-mlcommons-patch-4

Conversation

@mikek-mlcommons

Copy link
Copy Markdown
Contributor

…c_subset.csv to airr_official_1.0_DEMO_prompt_set_release_public_subset.csv

Adding DEMO to name to make it clear this is the demo prompt subset of the larger practice prompt set.

…c_subset.csv to airr_official_1.0_DEMO_prompt_set_release_public_subset.csv

Adding DEMO to name to make it clear this is the demo prompt subset of the larger practice prompt set.
@mikek-mlcommons
mikek-mlcommons requested a review from a team as a code owner March 12, 2025 20:46
@github-actions

Copy link
Copy Markdown

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

@wpietri wpietri left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unless you think otherwise, say we set this repo up so you are allowed to just merge things.

@rogthefrog

Copy link
Copy Markdown

@mikek-mlcommons @wpietri some of the code in modelgauge depends on the prompt set file names having a specific structure and they are case sensitive. This change should match that structure to prevent potential bugs in case we ever upload that file to modellab and reference it in tests, which has happened before.

I'm not in favor of file names being treated as structured UIDs and manually-managed file names in one system being hardcoded in another system, but it's what we have to work with now, so we should stick to that structure.

Reference:

https://github.com/mlcommons/modelbench/blob/602c62da73298b4ce683fb0c6d26af9d8d10bff1/src/modelgauge/prompt_sets.py#L22

My proposal for this file name:

Instead of:

airr_official_1.0_DEMO_prompt_set_release_public_subset.csv

Use:

airr_official_1.0_demo_prompt_set_release_subset.csv

"demo" in lowercase, and "demo" already implies public.

@mikek-mlcommons

Copy link
Copy Markdown
Contributor Author

@wpietri: Thanks!
@rogthefrog All lower case works for me if that's the standard elsewhere. I will rename this to match.

@mikek-mlcommons
mikek-mlcommons merged commit 3cbc2c5 into main Mar 17, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants