unshadow some errs

Author: mmlb

cmd/mistify-agent/main.go

@@ -53,7 +53,7 @@ func main() {
 		}).Fatal("failed to create agent context")
 	}
 
-	if err := ctx.CreateJobLog(); err != nil {
+	if err = ctx.CreateJobLog(); err != nil {
 		log.WithFields(log.Fields{
 			"error": err,
 			"func":  "ctx.CreateJobLog",

examples/simple-subagent/main.go

@@ -63,7 +63,7 @@ func main() {
 		}).Fatal(err)
 	}
 
-	if err := server.RegisterService(&s); err != nil {
+	if err = server.RegisterService(&s); err != nil {
 		log.WithFields(log.Fields{
 			"error": err,
 			"func":  "rpc.Server.RegisterService",

examples/test-rpc-service/main.go

@@ -337,7 +337,7 @@ func main() {
 	}
 
 	test := &Test{}
-	if err := s.RegisterService(test); err != nil {
+	if err = s.RegisterService(test); err != nil {
 		log.WithFields(log.Fields{
 			"error": err,
 			"func":  "rpc.Server.RegisterService",

examples/webhook-post/main.go

@@ -120,7 +120,7 @@ func main() {
 			Timeout: time.Second * 5,
 		},
 	}
-	if err := s.RegisterService(w); err != nil {
+	if err = s.RegisterService(w); err != nil {
 		log.WithFields(log.Fields{
 			"error": err,
 			"func":  "rpc.Server.RegisterService",

guest.go

@@ -131,7 +131,7 @@ func createGuest(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	if err := ctx.PersistGuest(g); err != nil {
+	if err = ctx.PersistGuest(g); err != nil {
 		hr.JSONError(http.StatusInternalServerError, err)
 		return
 	}
@@ -280,7 +280,7 @@ func generateGuestAction(actionName string) http.HandlerFunc {
 		g := getRequestGuest(r)
 		runner := getRequestRunner(r)
 
-		actionName := prefixedActionName(g.Type, actionName)
+		actionName = prefixedActionName(g.Type, actionName)
 		action, err := ctx.GetAction(actionName)
 		if err != nil {
 			hr.JSONError(http.StatusNotFound, err)

guestRunner.go

@@ -189,12 +189,12 @@ func (pq *PipelineQueue) Process() {
 					LogRunnerError(pq.GuestID, pq.Name, pipeline.ID, err.Error())
 				}
 				if err := pipeline.Run(); err != nil {
-					if err := pq.Context.JobLog.UpdateJob(pipeline.ID, pipeline.Action, Errored, err.Error()); err != nil {
+					if err = pq.Context.JobLog.UpdateJob(pipeline.ID, pipeline.Action, Errored, err.Error()); err != nil {
 						LogRunnerError(pq.GuestID, pq.Name, pipeline.ID, err.Error())
 					}
 					LogRunnerError(pq.GuestID, pq.Name, pipeline.ID, err.Error())
 				} else {
-					if err := pq.Context.JobLog.UpdateJob(pipeline.ID, pipeline.Action, Complete, ""); err != nil {
+					if err = pq.Context.JobLog.UpdateJob(pipeline.ID, pipeline.Action, Complete, ""); err != nil {
 						LogRunnerError(pq.GuestID, pq.Name, pipeline.ID, err.Error())
 					}
 					LogRunnerInfo(pq.GuestID, pq.Name, pipeline.ID, "Success")

rpc/client.go

@@ -45,7 +45,7 @@ func (c *Client) Do(method string, request interface{}, response interface{}) er
 
 	if resp.StatusCode >= http.StatusBadRequest {
 		var buf bytes.Buffer
-		if _, err := buf.ReadFrom(resp.Body); err != nil {
+		if _, err = buf.ReadFrom(resp.Body); err != nil {
 			return err
 		}
 		return errors.New(buf.String())
@@ -74,7 +74,7 @@ func (c *Client) DoRaw(request interface{}, rw http.ResponseWriter) {
 
 	if resp.StatusCode != http.StatusOK {
 		buf := new(bytes.Buffer)
-		if _, err := buf.ReadFrom(resp.Body); err != nil {
+		if _, err = buf.ReadFrom(resp.Body); err != nil {
 			http.Error(rw, err.Error(), http.StatusInternalServerError)
 			return
 		}