Adding delete selected options to toolbar options, etc.

[john-peterson]

No description provided.

[john-peterson]

Subversion

Notification

A notification about the existence of this mirror is at http://board.jdownloader.org/showthread.php?t=49098

Apply

Apply the patch with (replace # with the commit hash f.e. 0123456)

curl -s https://github.com/john-peterson/jdownloader/commit/#.patch | patch -p1 --binary

Author

Set the author at commit

svn ci --with-revprop svn:author="John Peterson <[email protected]>"

or after commit (replace # with the commit number)

svn propset svn:author --revprop -r # "John Peterson <[email protected]>"

because

• that associated the commit with my account at
  • https://github.com
  • https://www.ohloh.net

Message

Copy the commit message from

curl -s https://github.com/john-peterson/jdownloader/commit/#.patch | head -10

rather than writing another commit message

because

• the commit message should be written by the author

Write access

Wouldn't it make sense to commit these patches to the offical repo?

why do you not work with our svn repo directly?

Arguments regarding granting svn ci access to the author is

disadvantage

• the author can merge commits that aren't approved

benefit

• the author can have realised that the published patch should be changed before merge, but hasn't changed it yet or communicated this to potential committers, with the result that a committer merge the commit that the author intended to change before merge

If I'm requested to merge a commit instead of another person merging a commit I grant that request because

• it's not a significant work
• there are benefits (described above) with the author and committer being the same person

Converting to git

the project isn't converted from svn to git because

• it has a low priority because code commits for JDownloader 2 has a high priority

[john-peterson]

Adding formatter profile to project settings

Problem

When

• using default Eclipse settings
• adding the JDownloader project to Eclipse

the .settings/org.eclipse.jdt.ui.prefs setting

editor_save_participant_org.eclipse.jdt.ui.postsavelistener.cleanup=true

change the formatting described in the topic "Solution"

because the project files are saved with a formatting that differ from the default Eclipse 4.2 profile

formatter_profile=org.eclipse.jdt.ui.default.eclipse_profile

Solution

Adding a Properties > Java Code Style > Formatter profile to .settings/formatter.xls with the project settings

Import

The profile must be manually rather than non-manually imported because

• Eclipse doesn't support automatic formatter import from .settings

Formatter

Project settings [default]

• Indentation > Tab policy: Spaces only [Tabs only]
• Line Wrapping > Maximum line width: 140 [80]
• Comments > Maximum line width for comments: 140 [80]

[john-peterson]

Adding delete selected options to toolbar options

Problem

The delete selected options can't be added to the toolbar

This is a problem because it use three additional clicks before the action click

• (focus JDownloader if it's not already focused)
• (select Downloads tab if it's not already selected)
• Ctrl + A
• right click
• Delete selected
• action

Solution

Adding the options to optional toolbar actions

Reference

The code is copied from fd2cb26

Alternative solution

This problem is solved by another solution

• a "Delete links" drop down menu at the bottom of the "Downloads" tab

[john-peterson]

GitHub mirror

Compared to Redmine

The benefit with communication about code at GitHub compared to Redmine is

• the registration isn't public because this page http://svn.jdownloader.org/account/register is redirected to http://svn.jdownloader.org
• its beneficial that it's easy to change or communicate about software because that result in more beneficial changes and communication
• Markdown isn't enabled by default in Redmine

Benefit

The benefit with a GitHub mirror is

• some users prefer git over svn for creating and organising commits
• the option lead to higher utility because the author with a higher utility when using git can use it
• the net utility is higher because it's not a significant disadvantage to merge git commits with svn
• git pull is faster than svn update
• Travis CI notify the author if a pushed branch contain build errors

It's a significant inconvenience to track mirror activity

It's not a significant inconvenience to track GitHub repo activity because by selecting "Watching" "You receive notifications for all discussions in this repository"

Trademark

the mirror name shouldn't contain "JDownloader" because

• that can indicate that it's an official mirror
• it's a significant inconvenience to track mirror activity

It's not a significant inconvenience because of the arguments in the topic "Benefit"

• "JDownloader" is a registered trademark

Society's intention is that using "jdownloader" in the address https://github.com/mirror/jdownloader is fair use because

A nonowner may also use a trademark nominatively—to refer to the actual trademarked product or its source

It refer to the trademarked product rather than another product

Intent to sow confusion is also relevant

There isn't confusion that "jdownloader" refer to the Appwork GmbH trademark because

• the project description is "Unaffiliated with Appwork GmbH"

There's a logical reason for the address because

• the repos in https://github.com/mirror are named from the lowercase name of the origin repo name, that for this product is "jdownloader" in "svn://svn.jdownloader.org/jdownloader/trunk"

Appwork disagree that it's society's intention that the use is fair
if the trademark "JDownloader" isn't removed from the repo name by 2013-07-05 00:00 Appwork will complain to GitHub that a repo infringe on a trademark by containing a trademark name

The repo name is https://github.com/mirror/jd_unofficial because

• Appwork doesn't agree with the arguments in this topic
• it doesn't contain the trademark "JDownloader"

License

This topic describe society's intention regarding a mirror of code files

publishing work as a mirror of 'jdownloader' without permission has as copyright/trademark implications

The code license is GNU GPL 3

A mirror without permission is compliant with the intention of this license in the text

2. Basic Permissions.

You may make, run and propagate covered works that you do not convey, without conditions so long as your license otherwise remains in force.

A reasonable person don't believe that the mirror is endorsed by Appwork GmbH because

• the project description is "Unaffiliated with Appwork GmbH"

Permission

This Github mirror is not ours [JDownloader]

is this your github mirror?

I have member permission to this organisation which is

• changing organisation settings
• merge commits to master which isn't applicable for a mirror organisation because commits aren't merged to the mirror
• change comments in https://github.com/mirror/repo/issue/#

[john-peterson]

Changing the import toolbar menu title from "Export …" to "Import …"

Problem

The import toolbar menu title is "Export … " rather than "Import …"

This is a problem because

• the title "Import …" communicate the dialog purpose better than "Export … " because the dialog does an import rather than export

Solution

Changing the import toolbar menu title from "Export …" to "Import …" because

• that communicate the purpose of the dialog better
• the current name is unintentional