Fixed exception when paste polygon with ctrl hold (cvat-ai#9367)

Author: bsekachev

changelog.d/20250425_104058_sekachev.bs_fixed_exception.md

@@ -0,0 +1,4 @@
+### Fixed
+
+- UI crashes when paste cuboids with hold Ctrl key
+  (<https://github.com/cvat-ai/cvat/pull/9367>)

cvat-canvas/src/typescript/drawHandler.ts

@@ -1346,7 +1346,7 @@ export class DrawHandlerImpl implements DrawHandler {
             });
         }
 
-        if (this.drawInstance && (isFilalblePolygon)) {
+        if (this.drawInstance && isFilalblePolygon) {
             const paintHandler = this.drawInstance.remember('_paintHandler');
             if (paintHandler) {
                 for (const point of (paintHandler as any).set.members) {
@@ -1398,17 +1398,17 @@ export class DrawHandlerImpl implements DrawHandler {
         }
 
         if (this.drawInstance) {
-            this.drawInstance.draw('transform');
             this.drawInstance.attr({
                 'stroke-width': consts.BASE_STROKE_WIDTH / geometry.scale,
             });
 
             const paintHandler = this.drawInstance.remember('_paintHandler');
-
-            for (const point of (paintHandler as any).set.members) {
-                this.strokePoint(point);
-                point.attr('stroke-width', `${consts.POINTS_STROKE_WIDTH / geometry.scale}`);
-                point.attr('r', `${this.controlPointsSize / geometry.scale}`);
+            if (paintHandler) {
+                for (const point of (paintHandler as any).set.members) {
+                    this.strokePoint(point);
+                    point.attr('stroke-width', `${consts.POINTS_STROKE_WIDTH / geometry.scale}`);
+                    point.attr('r', `${this.controlPointsSize / geometry.scale}`);
+                }
             }
         }
     }

cvat-canvas/src/typescript/editHandler.ts

@@ -463,15 +463,13 @@ export class EditHandlerImpl implements EditHandler {
         }
 
         if (this.editLine) {
-            (this.editLine as any).draw('transform');
             if (this.editData.state.shapeType !== 'points') {
                 this.editLine.attr({
                     'stroke-width': consts.BASE_STROKE_WIDTH / geometry.scale,
                 });
             }
 
             const paintHandler = this.editLine.remember('_paintHandler');
-
             for (const point of paintHandler.set.members) {
                 point.attr('stroke-width', `${consts.POINTS_STROKE_WIDTH / geometry.scale}`);
                 point.attr('r', `${this.controlPointsSize / geometry.scale}`);

cvat-canvas/src/typescript/svg.patch.ts

@@ -59,33 +59,6 @@ SVG.Element.prototype.draw.extend(
     }),
 );
 
-// Create transform for rect, polyline and polygon
-function transform(): void {
-    this.m = this.el.node.getScreenCTM().inverse();
-    this.offset = { x: window.pageXOffset, y: window.pageYOffset };
-}
-
-SVG.Element.prototype.draw.extend(
-    'rect',
-    Object.assign({}, SVG.Element.prototype.draw.plugins.rect, {
-        transform: transform,
-    }),
-);
-
-SVG.Element.prototype.draw.extend(
-    'polyline',
-    Object.assign({}, SVG.Element.prototype.draw.plugins.polyline, {
-        transform: transform,
-    }),
-);
-
-SVG.Element.prototype.draw.extend(
-    'polygon',
-    Object.assign({}, SVG.Element.prototype.draw.plugins.polygon, {
-        transform: transform,
-    }),
-);
-
 export const CIRCLE_STROKE = '#000';
 // Fix method drawCircles
 function drawCircles(): void {