Simple browser widget doesn't go away when closing simple browser

[roblourens]

Screen.Recording.2025-05-02.at.6.44.15.PM.mov

[justschen]

interesting :0

cc @jrieken since i ripped this from the chatEditingEditorOverlay:

it looks like the following code is getting triggered with the signal, but is delayed somewhat between the activeEditorSignal.read step and the activeUriObs.read step. don't think i'm doing anything weird that would cause the hide() to be slow either:

const activeEditorSignal = observableSignalFromEvent(this, Event.any(group.onDidActiveEditorChange, group.onDidModelChange));

const activeUriObs = derivedOpts({ equalsFn: isEqual }, r => {

	activeEditorSignal.read(r); // signal

	const editor = group.activeEditorPane;
	if (editor?.input.editorId === 'mainThreadWebview-simpleBrowser.view') {
		const uri = EditorResourceAccessor.getOriginalUri(editor?.input, { supportSideBySide: SideBySideEditor.PRIMARY });
		return uri;
	}
	return undefined;
});

this._store.add(autorun(r => {
	const data = activeUriObs.read(r);

	if (!data) {
		hide();
		return;
	}

	show();
}));

tried something along the lines of this, subscribing directly to group.onDidActiveEditorChange and there was still a delay:

const disposable = group.onDidActiveEditorChange(() => {
	const editor = group.activeEditorPane;

	if (editor?.input.editorId === 'mainThreadWebview-simpleBrowser.view') {
		const data = EditorResourceAccessor.getOriginalUri(editor.input, {
			supportSideBySide: SideBySideEditor.PRIMARY
		});

		if (data) {
			show();
			return;
		}
	}

	hide();
});

this._store.add(disposable);

[justschen]

this one was fixed!

[roblourens]

Not quite. I click a rendered element in the chat debug view, then quickly click a text log entry instead (I do this really often because I accidentally click the rendered elements all the time)