Skip to content

[Bug]: Stack Overflow Deselecting All Changes in Schema Compare #19956

@Johare24

Description

@Johare24

Description

Expected the schema compare to deselect all changes when clicking the top most blue tick between source name and action. Instead it processes for a while and all changes remain selected. A stack overflow is reported in the output and the extension crashes.

The following is repeated excessively in the output:
Microsoft.SqlTools.ServiceLayer.SchemaCompare.SchemaCompareIncludeExcludeAllNodesOperation.IncludeExcludeAllDifferences(System.Collections.Generic.List`1<Microsoft.SqlServer.Dac.Compare.SchemaDifference>)

Steps to Reproduce

  1. Open sqlproj database project
  2. Right click and select Schema Compare (Preview)
  3. Select Database as Target and Connect to Database
  4. Switch Direction to make sqlproj the destination (Comparison kicks off on its own after this)
  5. Click the top most blue tick to deselect all changes.
  6. Extension should crash

Affected Area

  • Connection dialog
  • Query results panel
  • Query editor
  • Object Explorer
  • Table Designer
  • Schema Compare
  • Schema Designer
  • Local container
  • GitHub Copilot integration
  • Query Plan Visualizer
  • Other (please describe below)

If you selected "Other", please describe the affected area

No response

Environment Information

vs-code: 1.103.1
extension: 1.34.1
OS: Windows 10
Connection Type: Azure SQL

Confirmation

  • I have searched existing issues and couldn't find a match
  • I want to work on this issue

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions