Merge pull request #29 from jwittner/dev/scriptAnalyzerFixes

Dev/script analyzer fixes

Author: jwittner

UnitySetup/UnitySetup.psd1

@@ -61,7 +61,7 @@ RequiredModules = @(
 # RequiredAssemblies = @()
 
 # Script files (.ps1) that are run in the caller's environment prior to importing this module.
-ScriptsToProcess = @("UnitySetupInit.ps1")
+ScriptsToProcess = @()
 
 # Type files (.ps1xml) to be loaded when importing this module
 # TypesToProcess = @()

UnitySetup/UnitySetup.psm1

@@ -2,6 +2,27 @@
 # Licensed under the MIT License.
 Import-Module powershell-yaml -Force -ErrorAction Stop
 
+[Flags()] 
+enum UnitySetupComponentType
+{
+    Setup = (1 -shl 0)
+    Documentation = (1 -shl 1)
+    StandardAssets = (1 -shl 2)
+    ExampleProject = (1 -shl 3)
+    Metro = (1 -shl 4)
+    UWP_IL2CPP = (1 -shl 5)
+    Android = (1 -shl 6)
+    iOS = (1 -shl 7)
+    AppleTV = (1 -shl 8)
+    Facebook = (1 -shl 9)
+    Linux = (1 -shl 10)
+    Mac = (1 -shl 11)
+    Vuforia = (1 -shl 12)
+    WebGL = (1 -shl 13)
+    Windows_IL2CPP = (1 -shl 14)
+    All = (-1)
+}
+
 class UnitySetupInstaller
 {
     [UnitySetupComponentType] $ComponentType
@@ -228,6 +249,7 @@ function Find-UnitySetupInstaller
 function Install-UnitySetupInstance
 {
     [CmdletBinding()]
+    [System.Diagnostics.CodeAnalysis.SuppressMessageAttribute('PSAvoidUsingWriteHost', '', Scope='Function')]
     param(
        [parameter(ValueFromPipeline=$true)]
        [UnitySetupInstaller[]] $Installers,
@@ -496,7 +518,7 @@ function Get-UnityProjectInstance
 #>
 function Start-UnityEditor
 {
-    [CmdletBinding(DefaultParameterSetName="Context")]
+    [CmdletBinding(SupportsShouldProcess, DefaultParameterSetName="Context")]
     param(
         [parameter(Mandatory=$false, ValueFromPipeline = $true, ParameterSetName='Projects')]
         [parameter(Mandatory=$true, ValueFromPipeline = $true, ParameterSetName='ProjectsLatest')]
@@ -665,7 +687,11 @@ function Start-UnityEditor
                 $setProcessArgs['ArgumentList'] = $unityArgs
             }
 
-            Write-Verbose "Starting $editor $unityArgs"
+            if(-not $PSCmdlet.ShouldProcess("$editor $unityArgs", "Start-Process"))
+            {
+                continue
+            }
+
             $process = Start-Process @setProcessArgs
             if( $Wait )
             {