Fix pyright errors: use Sequence for batch method signatures

Change list to Sequence in add_terms_batch and add_properties_batch
interfaces and implementations to satisfy covariance. Add missing
add_terms_batch to FakeTermIndex in conftest.py.

Author: KRRT7

src/typeagent/knowpro/interfaces_core.py

@@ -4,6 +4,7 @@
 
 from __future__ import annotations
 
+from collections.abc import Sequence
 from datetime import datetime as Datetime
 from typing import (
     Any,
@@ -170,7 +171,7 @@ async def add_term(
 
     async def add_terms_batch(
         self,
-        terms: list[tuple[str, SemanticRefOrdinal | ScoredSemanticRefOrdinal]],
+        terms: Sequence[tuple[str, SemanticRefOrdinal | ScoredSemanticRefOrdinal]],
     ) -> None: ...
 
     async def remove_term(

src/typeagent/knowpro/interfaces_indexes.py

@@ -61,7 +61,7 @@ async def add_property(
 
     async def add_properties_batch(
         self,
-        properties: list[tuple[str, str, SemanticRefOrdinal | ScoredSemanticRefOrdinal]],
+        properties: Sequence[tuple[str, str, SemanticRefOrdinal | ScoredSemanticRefOrdinal]],
     ) -> None: ...
 
     async def lookup_property(

src/typeagent/storage/memory/propindex.py

@@ -1,6 +1,7 @@
 # Copyright (c) Microsoft Corporation.
 # Licensed under the MIT License.
 
+from collections.abc import Sequence
 import enum
 from typing import assert_never
 
@@ -156,7 +157,13 @@ def collect_action_properties(
     if action.object_entity_name != "none":
         props.append((PropertyNames.Object.value, action.object_entity_name, ordinal))
     if action.indirect_object_entity_name != "none":
-        props.append((PropertyNames.IndirectObject.value, action.indirect_object_entity_name, ordinal))
+        props.append(
+            (
+                PropertyNames.IndirectObject.value,
+                action.indirect_object_entity_name,
+                ordinal,
+            )
+        )
     return props
 
 
@@ -186,15 +193,23 @@ async def add_to_property_index(
             assert semantic_ref.semantic_ref_ordinal == semantic_ref_ordinal
             if isinstance(semantic_ref.knowledge, kplib.Action):
                 collected.extend(
-                    collect_action_properties(semantic_ref.knowledge, semantic_ref_ordinal)
+                    collect_action_properties(
+                        semantic_ref.knowledge, semantic_ref_ordinal
+                    )
                 )
             elif isinstance(semantic_ref.knowledge, kplib.ConcreteEntity):
                 collected.extend(
-                    collect_entity_properties(semantic_ref.knowledge, semantic_ref_ordinal)
+                    collect_entity_properties(
+                        semantic_ref.knowledge, semantic_ref_ordinal
+                    )
                 )
             elif isinstance(semantic_ref.knowledge, Tag):
                 collected.append(
-                    (PropertyNames.Tag.value, semantic_ref.knowledge.text, semantic_ref_ordinal)
+                    (
+                        PropertyNames.Tag.value,
+                        semantic_ref.knowledge.text,
+                        semantic_ref_ordinal,
+                    )
                 )
             elif isinstance(semantic_ref.knowledge, Topic):
                 pass
@@ -239,7 +254,9 @@ async def add_property(
 
     async def add_properties_batch(
         self,
-        properties: list[tuple[str, str, SemanticRefOrdinal | ScoredSemanticRefOrdinal]],
+        properties: Sequence[
+            tuple[str, str, SemanticRefOrdinal | ScoredSemanticRefOrdinal]
+        ],
     ) -> None:
         for name, value, ordinal in properties:
             await self.add_property(name, value, ordinal)

src/typeagent/storage/memory/semrefindex.py

@@ -3,11 +3,13 @@
 
 from __future__ import annotations  # TODO: Avoid
 
-from collections.abc import AsyncIterable, Callable
+from collections.abc import AsyncIterable, Callable, Sequence
 
 from typechat import Failure
 
-from ...knowpro import convknowledge, knowledge_schema as kplib, secindex
+from ...knowpro import convknowledge
+from ...knowpro import knowledge_schema as kplib
+from ...knowpro import secindex
 from ...knowpro.convsettings import ConversationSettings, SemanticRefIndexSettings
 from ...knowpro.interfaces import (  # Interfaces.; Other imports.
     IConversation,
@@ -711,7 +713,7 @@ async def add_term(
 
     async def add_terms_batch(
         self,
-        terms: list[tuple[str, SemanticRefOrdinal | ScoredSemanticRefOrdinal]],
+        terms: Sequence[tuple[str, SemanticRefOrdinal | ScoredSemanticRefOrdinal]],
     ) -> None:
         for term, ordinal in terms:
             await self.add_term(term, ordinal)

src/typeagent/storage/sqlite/propindex.py

@@ -3,6 +3,7 @@
 
 """SQLite-based property index implementation."""
 
+from collections.abc import Sequence
 import sqlite3
 
 from ...knowpro import interfaces
@@ -69,14 +70,21 @@ async def add_property(
 
     async def add_properties_batch(
         self,
-        properties: list[tuple[str, str, interfaces.SemanticRefOrdinal | interfaces.ScoredSemanticRefOrdinal]],
+        properties: Sequence[
+            tuple[
+                str,
+                str,
+                interfaces.SemanticRefOrdinal | interfaces.ScoredSemanticRefOrdinal,
+            ]
+        ],
     ) -> None:
         if not properties:
             return
         from ...storage.memory.propindex import (
             make_property_term_text,
             split_property_term_text,
         )
+
         rows = []
         for property_name, value, ordinal in properties:
             if isinstance(ordinal, interfaces.ScoredSemanticRefOrdinal):

src/typeagent/storage/sqlite/semrefindex.py

@@ -3,6 +3,7 @@
 
 """SQLite-based semantic reference index implementation."""
 
+from collections.abc import Sequence
 import re
 import sqlite3
 import unicodedata
@@ -58,7 +59,11 @@ async def add_term(
 
     async def add_terms_batch(
         self,
-        terms: list[tuple[str, interfaces.SemanticRefOrdinal | interfaces.ScoredSemanticRefOrdinal]],
+        terms: Sequence[
+            tuple[
+                str, interfaces.SemanticRefOrdinal | interfaces.ScoredSemanticRefOrdinal
+            ]
+        ],
     ) -> None:
         if not terms:
             return

tests/conftest.py

@@ -1,7 +1,7 @@
 # Copyright (c) Microsoft Corporation.
 # Licensed under the MIT License.
 
-from collections.abc import AsyncGenerator, Callable, Iterator
+from collections.abc import AsyncGenerator, Callable, Iterator, Sequence
 import os
 from pathlib import Path
 import tempfile
@@ -236,6 +236,13 @@ async def add_term(
         self.term_to_refs[term].append(scored_ref)
         return term
 
+    async def add_terms_batch(
+        self,
+        terms: Sequence[tuple[str, int | ScoredSemanticRefOrdinal]],
+    ) -> None:
+        for term, ordinal in terms:
+            await self.add_term(term, ordinal)
+
     async def remove_term(self, term: str, semantic_ref_ordinal: int) -> None:
         if term in self.term_to_refs:
             self.term_to_refs[term] = [