Expose fail-on-analysis-error flag (#307)

Co-authored-by: Andrew Petrochuk <[email protected]>

Author: petrochuk

check-solution/action.yml

@@ -48,6 +48,11 @@ inputs:
     description: The name of the artifact folder of which the PowerApps Checker logs will be uploaded.  Default value is \'CheckSolutionLogs\'
     required: false
 
+  fail-on-analysis-error:
+    description: Fail task if the Power Apps Checker analysis is returned as Failed or FinishedWithErrors. Default value is true
+    required: false
+    default: 'true'
+
 runs:
   using: 'node16'
   main: '../dist/actions/check-solution/index.js'

src/actions/check-solution/index.ts

@@ -21,14 +21,14 @@ import { runnerParameters } from '../../lib/runnerParameters';
         geoInstance: parameterMap["geo"],
         ruleLevelOverride: parameterMap["rule-level-override"],
         artifactStoreName: parameterMap["checker-logs-artifact-name"],
+        failOnAnalysisError: parameterMap["fail-on-analysis-error"],
         fileLocation: createEntry("fileLocation", "localFiles"),
         solutionUrl: createEntry("solutionUrl", ""),
         useDefaultPAEndpoint: createEntry("useDefaultPAEndpoint", true),
         customPAEndpoint: createEntry("customPAEndpoint", "https://unitedstates.api.advisor.powerapps.com/"),
         ruleSet: createEntry("ruleSet", "Solution Checker"),
         errorLevel: createEntry("errorLevel", "HighIssueCount"),
         errorThreshold: createEntry("errorThreshold", "0"),
-        failOnAnalysisError: createEntry("failOnAnalysisError", true),
         filesExcluded: createEntry("filesExcluded", "")
     }, runnerParameters, new ActionsHost('PowerAppsChecker'));
     core.endGroup();

src/test/checkSolution.test.ts

@@ -42,14 +42,14 @@ describe("check solution test", () => {
       geoInstance: { name: 'geo', required: false, defaultValue: undefined },
       ruleLevelOverride: { name: 'rule-level-override', required: false, defaultValue: undefined },
       artifactStoreName: { name: 'checker-logs-artifact-name', required: false, defaultValue: undefined },
+      failOnAnalysisError: { name: "fail-on-analysis-error", required: false, defaultValue: 'true' },
       fileLocation: { name: "fileLocation",  required: false, defaultValue: "localFiles" },
       solutionUrl: { name: "solutionUrl",  required: false, defaultValue: "" },
       useDefaultPAEndpoint: { name: "useDefaultPAEndpoint", required: false, defaultValue: true },
       customPAEndpoint: { name: "customPAEndpoint", required: false, defaultValue: "https://unitedstates.api.advisor.powerapps.com/" },
       ruleSet: { name: "ruleSet", required: false, defaultValue: "Solution Checker" },
       errorLevel: { name: "errorLevel", required: false, defaultValue: "HighIssueCount" },
       errorThreshold: { name: "errorThreshold", required: false, defaultValue: "0" },
-      failOnAnalysisError: { name: "failOnAnalysisError", required: false, defaultValue: true },
       filesExcluded: { name: "filesExcluded", required: false, defaultValue: ""}
     }, runnerParameters, new ActionsHost('PowerAppsChecker'));
   });