Skip to content

Commit 9adbf23

Browse files
authored
Quick fix for sub-orchestration gRPC serialization issue (#149)
1 parent 22af387 commit 9adbf23

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
### Updates
66

77
* Synchronous reads for improved performance for large payloads ([#134](https://github.com/microsoft/durabletask-mssql/pull/134)) - contributed by [@bhugot](https://github.com/bhugot)
8+
* Fix for sub-orchestration handling over gRPC ([#149](https://github.com/microsoft/durabletask-mssql/pull/149))
89

910
## v1.1.0
1011

src/DurableTask.SqlServer/SqlUtils.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ public static HistoryEvent GetHistoryEvent(this DbDataReader reader, bool isOrch
127127
historyEvent = new SubOrchestrationInstanceCreatedEvent(eventId)
128128
{
129129
Input = GetPayloadText(reader),
130-
InstanceId = null, // TODO
130+
InstanceId = "", // Placeholder - shouldn't technically be needed (adding it requires a SQL schema change)
131131
Name = GetName(reader),
132132
Version = null,
133133
};

0 commit comments

Comments
 (0)