enable nullable by default (#1471)

* enable Nullable

* removed some #nullable

* undo namespace changes

* undo Copilot namespace changes

* add back #nullable disables

* Add missing `#nullable disable` directives

---------

Co-authored-by: Jamie Magee <[email protected]>

Author: cataggar

.editorconfig

@@ -697,6 +697,12 @@ dotnet_diagnostic.CA1851.severity = suggestion
 # CA1861: Avoid constant arrays as arguments
 dotnet_diagnostic.CA1861.severity = suggestion
 
+# IDE0240: Nullable directive is redundant
+dotnet_diagnostic.IDE0240.severity = suggestion
+
+# IDE0241: Nullable directive is unnecessary
+dotnet_diagnostic.IDE0241.severity = suggestion
+
 # Workaround for https://github.com/dotnet/roslyn-analyzers/issues/5628
 [Program.cs]
 dotnet_diagnostic.ca1812.severity = none

Directory.Build.props

@@ -8,6 +8,7 @@
     <AnalysisLevel>latest</AnalysisLevel>
     <AnalysisMode>AllEnabledByDefault</AnalysisMode>
     <TreatWarningsAsErrors>true</TreatWarningsAsErrors>
+    <Nullable>enable</Nullable>
   </PropertyGroup>
 
   <PropertyGroup Label="Package">

src/Microsoft.ComponentDetection.Common/Column.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 public class Column

src/Microsoft.ComponentDetection.Common/CommandLineInvocationService.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 using System;

src/Microsoft.ComponentDetection.Common/ComponentComparer.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 using System.Collections.Generic;

src/Microsoft.ComponentDetection.Common/ComponentStream.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 using System.IO;

src/Microsoft.ComponentDetection.Common/ComponentStreamEnumerable.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 using System;

src/Microsoft.ComponentDetection.Common/DependencyGraph/ComponentRecorder.cs

@@ -1,3 +1,4 @@
+#nullable disable
 using System;
 using System.Collections.Concurrent;
 using System.Collections.Generic;

src/Microsoft.ComponentDetection.Common/DependencyGraph/DependencyGraph.cs

@@ -1,3 +1,4 @@
+#nullable disable
 using System;
 using System.Collections.Concurrent;
 using System.Collections.Generic;

src/Microsoft.ComponentDetection.Common/DirectoryItemFacade.cs

@@ -1,3 +1,4 @@
+#nullable disable
 namespace Microsoft.ComponentDetection.Common;
 
 using System.Collections.Generic;