Skip to content

Commit c1c4b8b

Browse files
authored
Enable NPM upload in release pipeline (#153)
This will (attempt to) publish winappcli to NPM next time we do a release. This PR doesn't update the docs about using NPM quite yet because we want to make sure the package successfully gets to npmjs first.
1 parent ac94c86 commit c1c4b8b

File tree

1 file changed

+38
-39
lines changed

1 file changed

+38
-39
lines changed

.pipelines/release.yml

Lines changed: 38 additions & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -174,45 +174,44 @@ extends:
174174
- ✅ Standalone CLI binaries (x64 and ARM64)
175175
- ✅ NPM package for NodeJS/Electron integration
176176
177-
# Commented out ESRP release to npm for now
178-
# - ${{ if eq(parameters.DoEsrp, 'true') }}:
179-
# - stage: Release_Npm
180-
# displayName: Create Npm Release
181-
# dependsOn: Release_GitHub
182-
# jobs:
183-
# - job: create_npm_release
184-
# pool:
185-
# name: Azure-Pipelines-1ESPT-ExDShared
186-
# image: windows-latest
187-
# os: windows
188-
# hostArchitecture: amd64
189-
# displayName: NPM Release
190-
# templateContext:
191-
# type: releaseJob
192-
# isProduction: true
193-
# inputs:
194-
# - input: pipelineArtifact
195-
# artifactName: npm-package
196-
# targetPath: $(Pipeline.Workspace)/npm-package
197-
# steps:
198-
# - task: EsrpRelease@10
199-
# condition: always()
200-
# inputs:
201-
# ConnectedServiceName: ${{ parameters.signingIdentity.serviceName }}
202-
# usemanagedidentity: true
203-
# keyvaultname: ${{ parameters.signingIdentity.akvName }}
204-
# signcertname: ${{ parameters.signingIdentity.signTTSCertName }}
205-
# clientid: ${{ parameters.signingIdentity.appId }}
206-
# intent: 'PackageDistribution'
207-
# contenttype: 'npm'
208-
# contentsource: 'Folder'
209-
# folderlocation: $(Pipeline.Workspace)/npm-package/
210-
# waitforreleasecompletion: true
211-
# owners: '$(EsrpOwnersEmail)'
212-
# approvers: '$(EsrpApproversEmail)'
213-
# serviceendpointurl: 'https://api.esrp.microsoft.com'
214-
# mainpublisher: 'winappcli'
215-
# domaintenantid: ${{ parameters.signingIdentity.tenantId }}
177+
- ${{ if eq(parameters.DoEsrp, 'true') }}:
178+
- stage: Release_Npm
179+
displayName: Create Npm Release
180+
dependsOn: Release_GitHub
181+
jobs:
182+
- job: create_npm_release
183+
pool:
184+
name: Azure-Pipelines-1ESPT-ExDShared
185+
image: windows-latest
186+
os: windows
187+
hostArchitecture: amd64
188+
displayName: NPM Release
189+
templateContext:
190+
type: releaseJob
191+
isProduction: true
192+
inputs:
193+
- input: pipelineArtifact
194+
artifactName: npm-package
195+
targetPath: $(Pipeline.Workspace)/npm-package
196+
steps:
197+
- task: EsrpRelease@10
198+
condition: always()
199+
inputs:
200+
ConnectedServiceName: ${{ parameters.signingIdentity.serviceName }}
201+
usemanagedidentity: true
202+
keyvaultname: ${{ parameters.signingIdentity.akvName }}
203+
signcertname: ${{ parameters.signingIdentity.signTTSCertName }}
204+
clientid: ${{ parameters.signingIdentity.appId }}
205+
intent: 'PackageDistribution'
206+
contenttype: 'npm'
207+
contentsource: 'Folder'
208+
folderlocation: $(Pipeline.Workspace)/npm-package/
209+
waitforreleasecompletion: true
210+
owners: '$(EsrpOwnersEmail)'
211+
approvers: '$(EsrpApproversEmail)'
212+
serviceendpointurl: 'https://api.esrp.microsoft.com'
213+
mainpublisher: 'winappcli'
214+
domaintenantid: ${{ parameters.signingIdentity.tenantId }}
216215

217216
- stage: Release_WinGet
218217
displayName: Create WinGet Release

0 commit comments

Comments
 (0)