Fix null safety issue in VerifyManifestAssetReferences

Copilot · azchohfi · Copilot · commit 4adfc5de9776 · 2025-11-06T22:14:49.000Z
Co-authored-by: azchohfi &lt;527713+azchohfi@users.noreply.github.com&gt;
diff --git a/src/winapp-CLI/WinApp.Cli/Commands/ManifestUpdateAssetsCommand.cs b/src/winapp-CLI/WinApp.Cli/Commands/ManifestUpdateAssetsCommand.cs
@@ -108,9 +108,9 @@ private void VerifyManifestAssetReferences(FileInfo manifestPath)
                     hasAssetReferences = true;
                 }
 
-                if (visualElementsNode != null)
+                if (visualElementsNode?.Attributes != null)
                 {
-                    foreach (XmlAttribute attr in visualElementsNode.Attributes!)
+                    foreach (XmlAttribute attr in visualElementsNode.Attributes)
                     {
                         if (attr.Value.Contains("Assets", StringComparison.OrdinalIgnoreCase))
                         {

Original file line number	Diff line number	Diff line change
`@@ -108,9 +108,9 @@ private void VerifyManifestAssetReferences(FileInfo manifestPath)`
`108`	`108`	`hasAssetReferences = true;`
`109`	`109`	`}`
`110`	`110`
`111`		`- if (visualElementsNode != null)`
	`111`	`+ if (visualElementsNode?.Attributes != null)`
`112`	`112`	`{`
`113`		`- foreach (XmlAttribute attr in visualElementsNode.Attributes!)`
	`113`	`+ foreach (XmlAttribute attr in visualElementsNode.Attributes)`
`114`	`114`	`{`
`115`	`115`	`if (attr.Value.Contains("Assets", StringComparison.OrdinalIgnoreCase))`
`116`	`116`	`{`