[#15] - Fix #15 and remove 'pr-comment' trigger as not functional

Signed-off-by: michmich112 <[email protected]>

Author: michmich112

README.md

@@ -242,7 +242,7 @@ interface BumpRule {
     /**
      * Action that triggers the bump to occur
      */
-    trigger: 'commit' | 'pull-request' | 'pr-comment' | 'manual',
+    trigger: 'commit' | 'pull-request' | 'manual',
 
 }
 ```

dist/rules/tests/isRuleApplicable.test.js

@@ -50,7 +50,7 @@ describe('[ RULE ] - isRuleApplicable', () => {
         const rule = {
             trigger: 'commit',
         };
-        const trigger = 'pr-comment';
+        const trigger = 'manual';
         const branch = 'randomBranch';
         expect(isRuleApplicable_1.default(rule, trigger, branch)).toBe(false);
     });

dist/utils/options.js

@@ -241,12 +241,12 @@ function getTrigger() {
             return 'commit';
         case 'pull_request':
             return 'pull-request';
-        case 'pull_request_review_comment':
-            return 'pr-comment';
+        // case 'pull_request_review_comment':
+        //   return 'pr-comment';
         case 'workflow_dispatch':
             return 'manual';
         default:
-            console.warn("Event trigger not of type: commit, pull request or pr-comment.");
+            console.warn("Event trigger not of type: commit, pull request or manual.");
             throw new Error("Invalid trigger event");
     }
 }

src/lib/types/OptionsFile.types.ts

@@ -68,7 +68,7 @@ export interface BumpRule {
      * Comment that triggers the rule
      * Only used when the trigger is pr-comment
      */
-    comment?: string,
+    // comment?: string,
 
     /**
      * Allows the bumper to create a commit tag for the bump
@@ -103,7 +103,7 @@ export interface BumpRule {
 }
 
 export type VersionScheme = 'custom' | any;
-export type RuleTrigger = 'commit' | 'pull-request' | 'pr-comment' | 'manual';
+export type RuleTrigger = 'commit' | 'pull-request' | 'manual'; //| 'pr-comment'
 export type VersionReleaseStatus = 'alpha' | 'beta' | 'release-candidate' | 'release';
 export type Seperators = '.' | ',' | ';' | ':' | '-' | '_' | '>' | '<';
 export const seperators: Seperators[] = ['.' , ',' , ';' , ':' , '-' , '_' , '>' , '<'];

src/rules/tests/isRuleApplicable.test.ts

@@ -51,7 +51,7 @@ describe('[ RULE ] - isRuleApplicable', () => {
     const rule: BumpRule = {
       trigger: 'commit',
     };
-    const trigger: RuleTrigger = 'pr-comment';
+    const trigger: RuleTrigger = 'manual';
     const branch = 'randomBranch';
     expect(isRuleApplicable(rule, trigger, branch)).toBe(false);
   });

src/utils/options.ts

@@ -6,8 +6,6 @@ import { bumpVersion, getCurVersion, getSchemeRegex, getTag } from "./utils";
 import * as core from '@actions/core';
 import * as github from '@actions/github';
 import * as fs from "fs";
-import { triggerAsyncId } from 'async_hooks';
-
 
 /**
  * Normalizes options by associating the scheme if user has selected a preset scheme
@@ -203,12 +201,12 @@ export function getTrigger(): RuleTrigger {
       return 'commit';
     case 'pull_request':
       return 'pull-request';
-    case 'pull_request_review_comment':
-      return 'pr-comment';
+    // case 'pull_request_review_comment':
+    //   return 'pr-comment';
     case 'workflow_dispatch':
       return 'manual';
     default:
-      console.warn("Event trigger not of type: commit, pull request or pr-comment.");
+      console.warn("Event trigger not of type: commit, pull request or manual.");
       throw new Error("Invalid trigger event");
   }
 }