Skip to content

malli.impl.util perf ideas #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

malli.impl.util perf ideas #1179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 21 additions & 12 deletions src/malli/impl/util.cljc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,14 @@
(defn -reduce-kv-valid [f init coll] (reduce-kv (comp #(-map-invalid reduced %) f) init coll))

(defn -last [x] (if (vector? x) (peek x) (last x)))
(defn -some [pred coll] (reduce (fn [ret x] (if (pred x) (reduced true) ret)) nil coll))
(defn -merge [m1 m2] (if m1 (persistent! (reduce-kv assoc! (transient m1) m2)) m2))

(defn -error
([path in schema value] {:path path, :in in, :schema schema, :value value})
([path in schema value type] {:path path, :in in, :schema schema, :value value, :type type}))

(defn -vmap
([os] (-vmap identity os))
([os] (if (vector? os) os (-vmap identity os)))
([f os] #?(:clj (let [c (count os)]
(if-not (zero? c)
(let [oa (object-array c), iter (.iterator ^Iterable os)]
Expand All @@ -41,33 +40,43 @@
#?(:clj
(defmacro -combine-n
[c n xs]
(assert (simple-symbol? xs))
(let [syms (repeatedly n gensym)
g (gensym "preds__")
bs (interleave syms (map (fn [n] `(nth ~g ~n)) (range n)))
bs (interleave syms (map (fn [n] `(nth ~xs ~n)) (range n)))
arg (gensym "arg__")
body `(~c ~@(map (fn [sym] `(~sym ~arg)) syms))]
`(let [~g (-vmap ~xs) ~@bs]
`(let [~@bs]
(fn [~arg] ~body)))))

#?(:clj (defmacro OR
([] false)
([x] `(if ~x true false))
([x & next] `(if ~x true (OR ~@next)))))

#?(:clj (defmacro AND
([] true)
([x] `(if ~x true false))
([x & next] `(if ~x (AND ~@next) false))))

#?(:clj
(defmacro -pred-composer
[c n]
(let [preds (gensym "preds__")
f (gensym "f__")
cases (mapcat (fn [i] [i `(-combine-n ~c ~i ~preds)]) (range 2 (inc n)))
else `(let [p# (~f (take ~n ~preds)) q# (~f (drop ~n ~preds))]
else `(let [p# (~f (subvec ~preds 0 ~n)) q# (~f (subvec ~preds ~n))]
(fn [x#] (~c (p# x#) (q# x#))))]
`(fn ~f [~preds]
(case (count ~preds)
0 (constantly (boolean (~c)))
1 (first ~preds)
0 (constantly (~c))
1 (nth ~preds 0)
~@cases
~else)))))

(def ^{:arglists '([[& preds]])} -every-pred
#?(:clj (-pred-composer and 16)
:cljs (fn [preds] (fn [m] (boolean (reduce #(or (%2 m) (reduced false)) true preds))))))
#?(:clj (-pred-composer AND 16)
:cljs (fn [preds] (fn [m] (reduce #(if (%2 m) true (reduced false)) true preds)))))

(def ^{:arglists '([[& preds]])} -some-pred
#?(:clj (-pred-composer or 16)
:cljs (fn [preds] (fn [x] (boolean (some #(% x) preds))))))
#?(:clj (-pred-composer OR 16)
:cljs (fn [preds] (fn [m] (reduce #(if (%2 m) (reduced true) false) false preds)))))