-
Notifications
You must be signed in to change notification settings - Fork 134
Bump versions #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump versions #582
Conversation
|
Ok that was not so straight forward... |
|
The issue is that the netlify builder we use is very old. We should bump to one that is Noble based probably. |
|
I am going to close this. We need to bump the netlify builder before we can do this anyway. In the mean time, #583 fixes the build container for local development. |
|
Created an issue to track: #584 |
6f04acd to
7ad811f
Compare
|
@fmuyassarov was able to update the netlify builder to Noble. Let's see how this works now |
7ad811f to
ea42323
Compare
|
This PR now includes the commit from #583 also. |
|
Let's leave this on hold until #583 is merged. It has all the changes to the dockerfile so they are neatly separated. After it is merged we can bump the versions here without affecting anything else. |
Signed-off-by: Lennart Jern <[email protected]>
Newer versions of mdbook does not allow two identical links apparently. This splits the BMO features into separate pages to avoid breaking this rule. ``` mdbook build docs/user-guide 2025-10-13 12:11:36 [ERROR] (mdbook::utils): Error: Summary parsing failed for file="/workdir/docs/user-guide/src/SUMMARY.md" 2025-10-13 12:11:36 [ERROR] (mdbook::utils): Caused By: Duplicate file in SUMMARY.md: "bmo/features.md" make: *** [Makefile:51: build] Error 101 ``` Signed-off-by: Lennart Jern <[email protected]>
ea42323 to
9a8c358
Compare
|
#583 is merged and I have rebased this. |
|
/lgtm |
|
/cc @kashifest |
kashifest
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kashifest The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We have been stuck on older versions due to #584.
The builder has been changed to use Noble now so we can bump the mdbook version. This PR also bumps the go version used to build the plugins for mdbook.
The newer version of mdbook is stricter with the summary table of content. We cannot have two links pointing to the same page, like we do for BMO basic and advanced features. To fix this I simply split it into two pages.
Maybe not the nicest solution. I am open to suggestions for how to do it instead. I tried using anchor links first but mdbook interpreted those as file names instead (e.g.
features.md#advanced).I have rebased this PR on top of #583 (that fixes the build container) and then bumped the build container here to noble instead of focal.
Fixes: #584