Skip to content

Conversation

@lentzi90
Copy link
Member

@lentzi90 lentzi90 commented Oct 13, 2025

We have been stuck on older versions due to #584.
The builder has been changed to use Noble now so we can bump the mdbook version. This PR also bumps the go version used to build the plugins for mdbook.

The newer version of mdbook is stricter with the summary table of content. We cannot have two links pointing to the same page, like we do for BMO basic and advanced features. To fix this I simply split it into two pages.
Maybe not the nicest solution. I am open to suggestions for how to do it instead. I tried using anchor links first but mdbook interpreted those as file names instead (e.g. features.md#advanced).

I have rebased this PR on top of #583 (that fixes the build container) and then bumped the build container here to noble instead of focal.

Fixes: #584

@metal3-io-bot metal3-io-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 13, 2025
@lentzi90
Copy link
Member Author

Ok that was not so straight forward...
/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 13, 2025
@lentzi90
Copy link
Member Author

The issue is that the netlify builder we use is very old. We should bump to one that is Noble based probably.
I'll see what I can do about that.

@lentzi90
Copy link
Member Author

I am going to close this. We need to bump the netlify builder before we can do this anyway. In the mean time, #583 fixes the build container for local development.

@lentzi90 lentzi90 mentioned this pull request Oct 14, 2025
@lentzi90
Copy link
Member Author

Created an issue to track: #584
Closing

@lentzi90 lentzi90 closed this Oct 14, 2025
@lentzi90 lentzi90 reopened this Oct 14, 2025
@lentzi90 lentzi90 force-pushed the lentzi90/bump-versions branch from 6f04acd to 7ad811f Compare October 14, 2025 07:32
@lentzi90
Copy link
Member Author

@fmuyassarov was able to update the netlify builder to Noble. Let's see how this works now

@lentzi90 lentzi90 force-pushed the lentzi90/bump-versions branch from 7ad811f to ea42323 Compare October 14, 2025 07:52
@lentzi90
Copy link
Member Author

This PR now includes the commit from #583 also.

@lentzi90
Copy link
Member Author

Let's leave this on hold until #583 is merged. It has all the changes to the dockerfile so they are neatly separated. After it is merged we can bump the versions here without affecting anything else.

Newer versions of mdbook does not allow two identical links apparently.
This splits the BMO features into separate pages to avoid breaking this
rule.

```
mdbook build docs/user-guide
2025-10-13 12:11:36 [ERROR] (mdbook::utils): Error: Summary parsing failed for file="/workdir/docs/user-guide/src/SUMMARY.md"
2025-10-13 12:11:36 [ERROR] (mdbook::utils): 	Caused By: Duplicate file in SUMMARY.md: "bmo/features.md"
make: *** [Makefile:51: build] Error 101
```

Signed-off-by: Lennart Jern <[email protected]>
@lentzi90 lentzi90 force-pushed the lentzi90/bump-versions branch from ea42323 to 9a8c358 Compare October 16, 2025 10:11
@lentzi90
Copy link
Member Author

#583 is merged and I have rebased this.
/hold cancel

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 16, 2025
@hroyrh
Copy link
Member

hroyrh commented Oct 16, 2025

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 16, 2025
@lentzi90
Copy link
Member Author

/cc @kashifest

Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2025
@metal3-io-bot metal3-io-bot merged commit 41f3c94 into metal3-io:main Oct 16, 2025
11 checks passed
@metal3-io-bot metal3-io-bot deleted the lentzi90/bump-versions branch October 16, 2025 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bump netlify builder

4 participants