Address review feedback

Changes:
1. Restore case-insensitive MAC comparison using strings.EqualFold()
   - The EqualFold check was removed inadvertently but is necessary for
     case-insensitive bootMACAddress validation

2. Use existing host.InspectionDisabled() method
   - Remove duplicate isInspectionDisabled() function
   - Replace custom implementation with the existing BareMetalHost method
   - The host.InspectionDisabled() method provides identical functionality

Assisted-by: Claude (AI Assistant)
Signed-off-by: Don Penney <[email protected]>

Author: donpenney

internal/webhooks/metal3.io/v1alpha1/baremetalhost_validation.go

@@ -109,7 +109,7 @@ func (webhook *BareMetalHost) validateChanges(oldObj *metal3api.BareMetalHost, n
 		errs = append(errs, errors.New("BMC address can not be changed if the BMH is not in the Registering state, or if the BMH is not detached"))
 	}
 
-	if oldObj.Spec.BootMACAddress != "" && newObj.Spec.BootMACAddress != oldObj.Spec.BootMACAddress {
+	if oldObj.Spec.BootMACAddress != "" && !strings.EqualFold(newObj.Spec.BootMACAddress, oldObj.Spec.BootMACAddress) {
 		errs = append(errs, errors.New("bootMACAddress can not be changed once it is set"))
 	}
 
@@ -120,19 +120,6 @@ func (webhook *BareMetalHost) validateChanges(oldObj *metal3api.BareMetalHost, n
 	return errs
 }
 
-// isInspectionDisabled checks if inspection is disabled via annotation or spec field.
-func isInspectionDisabled(host *metal3api.BareMetalHost) bool {
-	// Check the InspectionMode field first
-	if host.Spec.InspectionMode == metal3api.InspectionModeDisabled {
-		return true
-	}
-	// Check the annotation
-	if host.Annotations[metal3api.InspectAnnotationPrefix] == metal3api.InspectAnnotationValueDisabled {
-		return true
-	}
-	return false
-}
-
 func validateBMCAccess(host *metal3api.BareMetalHost, bmcAccess bmc.AccessDetails) []error {
 	var errs []error
 	s := host.Spec
@@ -156,7 +143,7 @@ func validateBMCAccess(host *metal3api.BareMetalHost, bmcAccess bmc.AccessDetail
 	// Check if bootMACAddress is required
 	requiresMAC := bmcAccess.NeedsMAC()
 	// Virtual media drivers (NeedsMAC() returns false) still require MAC when inspection is disabled
-	if !requiresMAC && isInspectionDisabled(host) {
+	if !requiresMAC && host.InspectionDisabled() {
 		requiresMAC = true
 	}