Skip to content

Bug in resize function caused by #1177 fix #1202

Open
@andyexeter

Description

@andyexeter

Test case: https://codepen.io/andyexeter/pen/mdBZJwb

Hey,

A bug has been introduced in 73249f9 which was added as a fix for #1177

Now that the resize function bails if the carousel is animating, triggering any elements within a cell to show on an adaptiveHeight carousel and then resizing doesn't work.

In the test case, if you scroll to cell 2 then click the "Show" button nothing happens. However, if you reload, scroll to cell 2 and wait a couple of seconds for the animation to settle and then click Show, the carousel is resized correctly to show the new visible content.

I've added a commented out temporary workaround to the test case, where I check the isAnimating property before calling resize and if it's true I wait for a settle event to fire before resizing. This kind of works, but there's a noticeable delay between clicking the button and the resize occurring.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions