Skip to content

pre-commit-clang-format not working on windows #370

Open
@pkspyder007

Description

@pkspyder007

🐛 Bug Report

Fix pre-commit-clang-format git hook to detect clang on windows and add v15 to the major version list.

Expected Behavior

Current Behavior

Clang-format is not detected even being installed already
image

image

Possible Solution

For adding v15 just add it to the this line https://github.com/metacall/core/blob/develop/githooks/pre-commit-clang-format#L27

Regarding the hook not detecting the clang-format executable, the current script is in bash if it could be ported to a .bat or .ps1 script for windows.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingdevopsRelated to DevOps infrastructure of the Coregood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions