MBS-14187: Don't block runeberg.org for non-works #3662
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only want to link this to works as lyrics, but since runeberg is basically just scans of books in the public domain, there are cases where it can be useful to link them to another type of entity; the example brought up was as a biography to an artist.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-14187
Description
We only want to link Project Runeberg to works as lyrics, but since the site is basically just scans of books in the public domain, there are cases where it can be useful to link them to another type of entity; the example brought up was as a biography to an artist. This just limits the lyrics-only restriction to works.
Testing
Added one test to the list to make sure the cleanup still works.