MBS-12751: Convert cdtoc/lookup to React #3660
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll need all of this in other files for converting cdtoc/list so this extracts the code into reusable components.
Mostly a straight conversion; it reuses existing code for showing the tracklist and for edit links. The used tracklist code displays in a different (but IMO better) way than the original, but contains the same data.
reosarevok
force-pushed
the
MBS-12751
branch
2 times, most recently
from
9798596 to
36723d1
Compare
Follows the same kind of structure as the other CDToc components. Ideally we should look into whether we can redesign these a bit to share the table and row components (with optional columns as needed). This seems to be the last use of cdtoc/list.tt so I'm dropping it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement MBS-12751
Description
Mostly a straight conversion; follows the same kind of structure as the other
CDToccomponents. Ideally we should look into whether we can redesign these a bit to share the table and row components (with optional columns as needed).This seems to be the last use of
cdtoc/list.ttso I'm dropping it.On top of #3658
Testing
Manually (with a full data tunnel):
/cdtoc/attach?toc=1+7+178280+150+17885+50412+71882+95892+118332+139512/cdtoc/attach?toc=1+8+178280+150+17885+50412+71882+95892+118332+139512+156820/cdtoc/attach?toc=1%2016%20256350%20150%2016761%2036190%2052813%2065402%2080507%2098599%20116776%20134513%20150750%20168208%20186828%20199204%20211272%20224903%20243845/cdtoc/attach?toc=1%2017%20250200%20182%2021195%2034730%2046842%2058852%2068412%2078377%2091460%20101300%20125202%20136140%20146205%20160920%20170627%20185555%20198165%20238575