Make multipart default (#1113)

Summary:
Pull Request resolved: #1113

I have been using it in perf tests. It looks good so far. Make it default.

Reviewed By: mariusae

Differential Revision: D81800129

fbshipit-source-id: 79b61ac5123b5289d0d795fc18a57bcc4452342f

Author: pzhan9

hyperactor/src/config.rs

@@ -52,10 +52,10 @@ declare_attrs! {
     pub attr REMOTE_ALLOCATOR_HEARTBEAT_INTERVAL: Duration = Duration::from_secs(5);
 
     /// The default encoding to be used.
-    pub attr DEFAULT_ENCODING: Encoding = Encoding::Bincode;
+    pub attr DEFAULT_ENCODING: Encoding = Encoding::Multipart;
 
     /// Whether to use multipart encoding for network channel communications.
-    pub attr CHANNEL_MULTIPART: bool = false;
+    pub attr CHANNEL_MULTIPART: bool = true;
 
     /// How often to check for full MSPC channel on NetRx.
     pub attr CHANNEL_NET_RX_BUFFER_FULL_CHECK_INTERVAL: Duration = Duration::from_secs(5);

hyperactor/src/data.rs

@@ -777,7 +777,7 @@ mod tests {
         let serialized = Serialized::serialize(&data).unwrap();
         let serialized_json = serialized.clone().transcode_to_json().unwrap();
 
-        assert!(serialized.encoded.is_bincode());
+        assert!(serialized.encoded.is_multipart());
         assert!(serialized_json.encoded.is_json());
 
         let json_string =
@@ -816,6 +816,8 @@ mod tests {
 
     #[test]
     fn test_emplace_prefix() {
+        let config = config::global::lock();
+        let _guard = config.override_key(config::DEFAULT_ENCODING, Encoding::Bincode);
         let data = TestDumpStruct {
             a: "hello".to_string(),
             b: 1234,

hyperactor_mesh/src/actor_mesh.rs

@@ -683,6 +683,7 @@ mod tests {
     use hyperactor::ProcId;
     use hyperactor::WorldId;
     use hyperactor::attrs::Attrs;
+    use hyperactor::data::Encoding;
     use timed_test::async_timed_test;
 
     use super::*;
@@ -1328,6 +1329,9 @@ mod tests {
             unsafe {
                 std::env::set_var("HYPERACTOR_CODEC_MAX_FRAME_LENGTH", "1024");
             };
+            let _guard3 =
+                config.override_key(hyperactor::config::DEFAULT_ENCODING, Encoding::Bincode);
+            let _guard4 = config.override_key(hyperactor::config::CHANNEL_MULTIPART, false);
 
             let alloc = process_allocator()
                 .allocate(AllocSpec {