Commit 64d0c67
Add non-abstract poll_exception method to MyRunner in custom botorch model tutorial (#2087)
Summary:
## Motivation
[Ax https://github.com/pytorch/botorch/issues/1958](https://github.com/facebook/Ax/pull/1958) broke the custom botorch model tutorial by adding an abstract method to the `Runner` class; the tutorial contained a `Runner` subclass that did not override this method. I fixed this by adding a method that returns a `NotImplementedError`.
Pull Request resolved: #2087
Test Plan: Ran tutorial locally: `python scripts/run_tutorials.py -p "$(pwd)" -s -n custom_botorch_model_in_ax.ipynb`
Reviewed By: saitcakmak
Differential Revision: D51046160
Pulled By: esantorella
fbshipit-source-id: dd3b86f379f44be51fda01cbc412559a1e84b4751 parent 7d90433 commit 64d0c67
1 file changed
+9
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
94 | | - | |
95 | 94 | | |
96 | 95 | | |
97 | 96 | | |
| |||
1140 | 1139 | | |
1141 | 1140 | | |
1142 | 1141 | | |
| 1142 | + | |
| 1143 | + | |
| 1144 | + | |
| 1145 | + | |
| 1146 | + | |
| 1147 | + | |
| 1148 | + | |
| 1149 | + | |
| 1150 | + | |
1143 | 1151 | | |
1144 | 1152 | | |
1145 | 1153 | | |
| |||
0 commit comments