@@ -21,6 +21,9 @@ var meshsyncLibraryWithK8SClusterCustomBrokerTestCaseData []meshsyncLibraryWithK
2121 {
2222 name : "output mode channel: number of messages received from meshsync is greater than zero" ,
2323 meshsyncRunOptions : []libmeshsync.OptionsSetter {
24+ // adding nil to options to test that meshsync can handle nil options setter
25+ // must not fail when has nil in options setter
26+ nil ,
2427 libmeshsync .WithOutputMode (config .OutputModeBroker ),
2528 libmeshsync .WithBrokerHandler (channel .NewChannelBrokerHandler ()),
2629 libmeshsync .WithStopAfterDuration (8 * time .Second ),
@@ -50,18 +53,6 @@ var meshsyncLibraryWithK8SClusterCustomBrokerTestCaseData []meshsyncLibraryWithK
5053 },
5154 },
5255 // TODO
53- // remove this as a separate test case,
54- // add nil to []libmeshsync.OptionsSetter in the previous test case with a comment
55- {
56- name : "output mode channel: must not fail when has nil in options setter" ,
57- meshsyncRunOptions : []libmeshsync.OptionsSetter {
58- nil ,
59- libmeshsync .WithOutputMode (config .OutputModeBroker ),
60- libmeshsync .WithBrokerHandler (channel .NewChannelBrokerHandler ()),
61- libmeshsync .WithStopAfterDuration (0 * time .Second ),
62- },
63- },
64- // TODO
6556 // this is not an output mode test
6657 // we do not need to run libmeshsync.Run, as we only test call to GetClusterID
6758 // we still need k8s cluster in place;
0 commit comments