Skip to content

Conversation

@parthivsaikia
Copy link
Contributor

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Description

This PR implements standard "exit" behaviors for the Shape Builder tool to match common UX patterns.

Changes:

  1. Logic (ShapeBuilder.js):

    • Added event listener for Escape key to close the shape.
    • Added onDoubleClick event to the drawing canvas to close the shape.
    • Refactored the "Close Shape" logic into a reusable finishShape function.
  2. UI (index.js):

    • Updated the instructions bar to explicitly list ENTER / ESC as valid closing keys.
    • (Note: Applies the "Keyboard Style" UI updates to ensure the ESC key is displayed clearly).

Testing

  • Tested Escape key while drawing -> Closes and fills shape.
  • Tested Double Click on grid -> Closes and fills shape.
  • Verified Enter key still works as expected.

Screenshots

Signed-off-by: PARTHIV PRATIM SAIKIA <[email protected]>
@saurabhraghuvanshii
Copy link
Contributor

thanks @parthivsaikia lgtm

@saurabhraghuvanshii saurabhraghuvanshii merged commit 86e49f1 into meshery-extensions:master Dec 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add esc and double tab feature to exit shape builder

3 participants