[Shape-builder]: enable ESC and Double Click to close shape #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
Signed commits
Description
This PR implements standard "exit" behaviors for the Shape Builder tool to match common UX patterns.
Changes:
Logic (
ShapeBuilder.js):Escapekey to close the shape.onDoubleClickevent to the drawing canvas to close the shape.finishShapefunction.UI (
index.js):ENTER / ESCas valid closing keys.Testing
Escapekey while drawing -> Closes and fills shape.Enterkey still works as expected.Screenshots