-
-
Notifications
You must be signed in to change notification settings - Fork 8.4k
fix : improved sequence diagram new actors rendering and autonumber positioning for all types of arrows and central connections #7150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for mermaid-js ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
@mermaid-js/examples
mermaid
@mermaid-js/layout-elk
@mermaid-js/layout-tidy-tree
@mermaid-js/mermaid-zenuml
@mermaid-js/parser
@mermaid-js/tiny
commit: |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #7150 +/- ##
==========================================
- Coverage 3.55% 3.54% -0.01%
==========================================
Files 473 474 +1
Lines 47500 47599 +99
Branches 731 731
==========================================
Hits 1687 1687
- Misses 45813 45912 +99
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
…r all arrow types and connections
…fix/sequence-diagram-autonumber-arrow-positioning
📑 Summary
This PR fixes critical autonumber positioning issues for sequence diagrams across all arrow types, adds missing helper functions, and improves actor rendering consistency.
Key Changes:
1. Fixed Autonumber Positioning (
sequenceRenderer.ts)2. Enhanced Central Connection Rendering (
sequenceRenderer.ts)getCircleOffset()helper function with directional logic (LTR/RTL)CENTRAL_CONNECTION- circle at destinationCENTRAL_CONNECTION_REVERSE- circle at sourceCENTRAL_CONNECTION_DUAL- circles at both ends3. Improved Actor Rendering (
svgDraw.js)Resolves #
📏 Design Decisions
Describe the way your implementation works or what design decisions you made if applicable.
📋 Tasks
Make sure you
MERMAID_RELEASE_VERSIONis used for all new features.pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.