C# add ShowMatchesPosition in SearchQuery setting made search output error

[jennyesoo]

Describe the bug
Using ShowMatchesPosition in a SearchQuery, the search output fails to match the structure.

To Reproduce
Steps to reproduce the behavior:

• SearchQuery setting

SearchQuery query = new SearchQuery { ShowMatchesPosition = true };

• output is

• I would like to search some query and then get error.

code is
ISearchable<IReadOnlyDictionary<string, string>> output = await _client.Index(_indexName).SearchAsync<IReadOnlyDictionary<string, string>>(input, query);

Error is
System.Text.Json.JsonException: 'The JSON value could not be converted to System.String. Path: $.hits[0]._matchesPosition | LineNumber: 0 | BytePositionInLine: 36568.'

• check if There is an issue with the output structure in Meilisearch.ISearchable.cs

Expected behavior
The SearchAsync can be used flexibly.
ISearchable<T> output = await _client.Index(_indexName).SearchAsync<T>(input, query);

Meilisearch version:
Melisearch - [v1.2.0-rc.3]
C# -

[alallema]

Hi @jennyesoo,
Thanks for raising this issue! It's the week of the engine release, so I'll take a look as soon as I can.

[jennyesoo]

Hi @jennyesoo, Thanks for raising this issue! It's the week of the engine release, so I'll take a look as soon as I can.

Thanks @alallema .

[ahmednfwela]

This is not a bug actually, you are deserializing to Dictionary<string, string> and since _matchesPosition is not a string, it will throw.

I suggest deserializing to JsonObject instead

[alallema]

Thank you so much @ahmednfwela, you're absolutely right 🚀. Sorry I didn't read more carefully.
On that note I will close this issue because this is not a bug.

[jennyesoo]

Hi, @ahmednfwela @alallema , thank you for your response.
I have now completed the conversion of the output to parse the JsonObject.
However, that is not the main point I want to emphasize.

When using ShowMatchesPosition, it generates two different output structures. My expectation is that SearchAsync should be flexible enough to handle these structures without requiring users to manually parse the JSON. Furthermore, ISearchable is unable to accurately interpret the structure.

I hope this conveys my intended message.

[ahmednfwela]

@jennyesoo a similar situation is addressed here for _formatted
#406