Do not convert missing value to eltype of CFDiskArray #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 24, 2025 16:06
According to the CF Conventions https://cfconventions.org/Data/cf-conventions/cf-conventions-1.12/cf-conventions.html#missing-data the missing data check should be done on the raw data before applying offset and scale_factor. Therefore it should also be in the element type of the raw data.
The missing_value would be missed, if we convert it to the element type because of Floating point inaccuracies.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #30 +/- ##
==========================================
+ Coverage 73.72% 75.42% +1.69%
==========================================
Files 1 1
Lines 236 236
==========================================
+ Hits 174 178 +4
+ Misses 62 58 -4 ☔ View full report in Codecov by Sentry. |
meggart
approved these changes
Jan 27, 2025
Owner
meggart
left a comment
meggart
left a comment
There was a problem hiding this comment.
Yes, this makes sense. Thanks a lot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the CF Conventions https://cfconventions.org/Data/cf-conventions/cf-conventions-1.12/cf-conventions.html#missing-data the missing data check should be done on the raw data before applying offset and scale_factor. Therefore it should also be in the element type of the raw data.
This would fix the missing value problems I have at RQADeforestation.jl
Tests are added and this is good to go.