remove todo

Author: pidoubleyou

src/main/java/de/mediathekview/mserver/crawler/zdf/json/ZdfTopicBaseClass.java

@@ -16,9 +16,11 @@
 
 public class ZdfTopicBaseClass {
   private static final String PLACEHOLDER_PLAYER_ID = "{playerId}";
-  // todo check if this is the correct player id
   private static final String PLAYER_ID = "android_native_5";
 
+  public static final String ELEMENT_EPISODE_INFO = "episodeInfo";
+  public static final String ELEMENT_VIDEO = "video";
+
   private static final Logger LOG = LogManager.getLogger(ZdfTopicBaseClass.class);
 
   private static final DateTimeFormatter DATE_FORMATTER_EDITORIAL =
@@ -75,13 +77,13 @@ private Optional<String> parseTitle(final JsonObject episodeObject) {
     Optional<String> resultingTitle = formatTitle(title, subtitle);
 
     if (resultingTitle.isPresent()) {
-      if (episodeObject.has("episodeInfo")) {
+      if (episodeObject.has(ELEMENT_EPISODE_INFO)) {
         final Optional<Integer> season =
             JsonUtils.getAttributeAsInt(
-                episodeObject.getAsJsonObject("episodeInfo"), "seasonNumber");
+                episodeObject.getAsJsonObject(ELEMENT_EPISODE_INFO), "seasonNumber");
         final Optional<Integer> episode =
             JsonUtils.getAttributeAsInt(
-                episodeObject.getAsJsonObject("episodeInfo"), "episodeNumber");
+                episodeObject.getAsJsonObject(ELEMENT_EPISODE_INFO), "episodeNumber");
         final Optional<String> seasonEpisodeTitle = formatEpisodeTitle(season, episode);
         return cleanupTitle((resultingTitle.get() + " " + seasonEpisodeTitle.orElse("")).trim());
       } else {
@@ -125,8 +127,8 @@ private Optional<String> cleanupTitle(String title) {
 
   private JsonArray getMediaNodes(JsonObject episodeObject) {
     JsonObject videoRootObject = episodeObject;
-     if (episodeObject.has("video") && !episodeObject.get("video").isJsonNull()) {
-      videoRootObject = episodeObject.getAsJsonObject("video");
+     if (episodeObject.has(ELEMENT_VIDEO) && !episodeObject.get(ELEMENT_VIDEO).isJsonNull()) {
+      videoRootObject = episodeObject.getAsJsonObject(ELEMENT_VIDEO);
     }
     if (!videoRootObject.has("currentMedia")) {
       return new JsonArray();
@@ -140,7 +142,7 @@ private Optional<String> parseSender(JsonObject episodeObject) {
       return Optional.empty();
     }
     final Optional<JsonElement> trackingVideoElement =
-        JsonUtils.getElement(episodeObject, "tracking", "piano", "video");
+        JsonUtils.getElement(episodeObject, "tracking", "piano", ELEMENT_VIDEO);
     if (trackingVideoElement.isEmpty() || trackingVideoElement.get().isJsonNull()) {
       return Optional.empty();
     }