-
Notifications
You must be signed in to change notification settings - Fork 23k
Defenses pages #42158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defenses pages #42158
Conversation
Preview URLs (9 pages)
Flaws (9)Note! 4 documents with no flaws that don't need to be listed. 🎉 URL:
URL:
URL:
URL:
URL:
(comment last updated: 2025-11-28 19:16:41) |
chrisdavidmills
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wbamberg This all sounds pretty much fine to me. I just had a few grammar nits for you, plus a question about the transient/sticky activation definition. I'll approve it though, so you can get it merged after you've looked them over.
| As a rule, there's a many to many relationship between attacks and defenses. In each of our [attacks guides](/en-US/docs/Web/Security/Attacks) we describe the specific defenses against that attack. In the defenses pages listed below, we'll provide a broader overview of what some of these defenses are and how they work. | ||
|
|
||
| - [Certificate transparency](/en-US/docs/Web/Security/Defenses/Mixed_content) | ||
| - : Certificate transparency provides a publicly visible log of issued {{glossary("TLS")}} certificates, making it easier to detect those which were malicious or incorrectly issued. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to repeat the feature name from the DD at the start of the DT in each case? It works in some cases, but I think it sounds a little repetitive as-is. Not a major problem...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I agree. what do you suggest though? Just omitting the subject?
| - : Certificate transparency provides a publicly visible log of issued {{glossary("TLS")}} certificates, making it easier to detect those which were malicious or incorrectly issued. | |
| - : Provides a publicly visible log of issued {{glossary("TLS")}} certificates, making it easier to detect those which were malicious or incorrectly issued. |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 79287c8.
Co-authored-by: Chris Mills <[email protected]>
This is another bit of https://github.com/orgs/mdn/discussions/857.
It's pretty conservative: I have only moved pages under a new "Defenses" page, and not changed them at all.
In a subsequent PR, I will rewrite the TLS page, and I might try to integrate "Mixed content" and "Certificate transparency" into that page then.