Skip to content

Commit 78a053b

Browse files
pm215Fabiano Rosas
authored andcommitted
tests/qtest/migration-test: Don't strdup in get_dirty_rate()
We g_strdup() the "status" string we get out of the qdict in get_dirty_rate(), but we never free it. Since we only use this string while the dictionary is still valid, we don't need to strdup at all; drop the unnecessary call to avoid this leak: Direct leak of 18 byte(s) in 2 object(s) allocated from: #0 0x564b3e01913e in malloc (/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/asan/tests/qtest/migration-test+0x22f13e) (BuildId: d6403a811332fcc846f93c45e23abfd06d1e67c4) #1 0x7f2f278ff738 in g_malloc debian/build/deb/../../../glib/gmem.c:128:13 #2 0x7f2f27914583 in g_strdup debian/build/deb/../../../glib/gstrfuncs.c:361:17 #3 0x564b3e14bb5b in get_dirty_rate tests/qtest/migration-test.c:3447:14 #4 0x564b3e138e00 in test_vcpu_dirty_limit tests/qtest/migration-test.c:3565:16 qemu#5 0x564b3e14f417 in migration_test_wrapper tests/qtest/migration-helpers.c:456:5 Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Fabiano Rosas <[email protected]> Signed-off-by: Fabiano Rosas <[email protected]>
1 parent 6ed8c95 commit 78a053b

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tests/qtest/migration-test.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3355,7 +3355,7 @@ static void wait_for_calc_dirtyrate_complete(QTestState *who,
33553355
static int64_t get_dirty_rate(QTestState *who)
33563356
{
33573357
QDict *rsp_return;
3358-
gchar *status;
3358+
const char *status;
33593359
QList *rates;
33603360
const QListEntry *entry;
33613361
QDict *rate;
@@ -3364,7 +3364,7 @@ static int64_t get_dirty_rate(QTestState *who)
33643364
rsp_return = query_dirty_rate(who);
33653365
g_assert(rsp_return);
33663366

3367-
status = g_strdup(qdict_get_str(rsp_return, "status"));
3367+
status = qdict_get_str(rsp_return, "status");
33683368
g_assert(status);
33693369
g_assert_cmpstr(status, ==, "measured");
33703370

0 commit comments

Comments
 (0)