Skip to content

Commit 19fac01

Browse files
committed
UPSTREAM: <carry>: Fix downstream VPA e2e for compatibility
Currently we have to: * Skip an admission-controller e2e test which reloads certs, since we don't support this Signed-off-by: Max Cao <[email protected]>
1 parent 31b44d9 commit 19fac01

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

vertical-pod-autoscaler/e2e/v1/admission_controller.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -894,6 +894,9 @@ var _ = AdmissionControllerE2eDescribe("Admission-controller", ginkgo.Label("FG:
894894
})
895895

896896
ginkgo.It("reloads the webhook leaf and CA certificate", func(ctx ginkgo.SpecContext) {
897+
// TODO(maxcao13): We need to carry patch this to skip this on OpenShift
898+
ginkgo.Skip("Skipping test on OpenShift because we don't deploy VPA with these certs")
899+
897900
ginkgo.By("Retrieving alternative certificates")
898901
c := f.ClientSet
899902
e2eCertsSecret, err := c.CoreV1().Secrets(metav1.NamespaceSystem).Get(ctx, "vpa-e2e-certs", metav1.GetOptions{})

0 commit comments

Comments
 (0)