-
Notifications
You must be signed in to change notification settings - Fork 26
Description
This is a great tool! However as I started working with it on a batch of URLs I needed to validate, I ran into a couple of problems:
-
HTTP status code 308 Permanent Redirect: This is much less used than 301 (in fact I had forgotten it existed until now), but apparently some sites are using it. I was able to patch this easily by just adding
|| $this->status == 308to the conditional in thehasRedirectHTTPStatus()method (~line 608 of URLResolver.php). -
Capitalization in hostnames: The data I was provided had some instances where a domain name included capitalization. It's possible there's a setting for handling this that I just missed, but I found the capitalization just caused URLResolver to return the original URL, with a 404 status. (In this case, I wrote my own code that converts the hostname to lowercase before passing it to URLResolver.)