From c46f568bd5f884f8574e6bf817df4a02731636cf Mon Sep 17 00:00:00 2001 From: Matthew Gladman Date: Wed, 22 Mar 2023 18:22:52 +1100 Subject: [PATCH 1/3] Use check-runs --- .github/workflows/node.js.yml | 6 +++++- src/middlewares/LambdaEventMiddleware.ts | 2 +- src/tests/SimpleRoute.test.ts | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml index efb6037..c375d91 100644 --- a/.github/workflows/node.js.yml +++ b/.github/workflows/node.js.yml @@ -24,4 +24,8 @@ jobs: npm install sfdx-cli npx sfdx plugins:install @salesforce/sfdx-scanner - name: SFDX Scanner - uses: mattisdada/sfdx-scan-pull-request@main + uses: mattisdada/sfdx-scan-pull-request@ts-port + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + with: + report-mode: check-runs diff --git a/src/middlewares/LambdaEventMiddleware.ts b/src/middlewares/LambdaEventMiddleware.ts index 5282527..59fd85f 100644 --- a/src/middlewares/LambdaEventMiddleware.ts +++ b/src/middlewares/LambdaEventMiddleware.ts @@ -1,6 +1,6 @@ import { HttpRequest } from "../HttpRequest"; import { HttpResponse } from "../HttpResponse"; -import { BeforeMiddleware } from "../SimpleRouter"; +import { BeforeMiddleware, HttpCodes } from "../SimpleRouter"; export class LambdaEventMiddleware implements BeforeMiddleware { async before(request: HttpRequest, response: HttpResponse, context: any) { diff --git a/src/tests/SimpleRoute.test.ts b/src/tests/SimpleRoute.test.ts index 25e9311..c04386f 100644 --- a/src/tests/SimpleRoute.test.ts +++ b/src/tests/SimpleRoute.test.ts @@ -1,4 +1,6 @@ -import { AfterMiddleware, BeforeMiddleware, HttpCodes, HttpRequest, HttpResponse, Router } from "../SimpleRouter"; +import { AfterMiddleware, BeforeMiddleware, HttpCodes, Router } from "../SimpleRouter"; +import { HttpRequest } from "../HttpRequest"; +import { HttpResponse } from "../HttpResponse"; test("create middleware", async () => { //const router = new Router(); From f9f9d87312a96e4bb0a8bde7f74b2d5f299dad39 Mon Sep 17 00:00:00 2001 From: Matthew Gladman Date: Wed, 22 Mar 2023 18:23:42 +1100 Subject: [PATCH 2/3] Use comments --- .github/workflows/node.js.yml | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/node.js.yml b/.github/workflows/node.js.yml index c375d91..93cba76 100644 --- a/.github/workflows/node.js.yml +++ b/.github/workflows/node.js.yml @@ -28,4 +28,6 @@ jobs: env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} with: - report-mode: check-runs + report-mode: comments + delete-resolved-comments: true + From d4f9e9829d13ac60bf58c3ac48996610e7becfce Mon Sep 17 00:00:00 2001 From: Matthew Gladman Date: Wed, 22 Mar 2023 19:09:02 +1100 Subject: [PATCH 3/3] Remove one lint issue --- src/middlewares/LambdaEventMiddleware.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/middlewares/LambdaEventMiddleware.ts b/src/middlewares/LambdaEventMiddleware.ts index 59fd85f..5282527 100644 --- a/src/middlewares/LambdaEventMiddleware.ts +++ b/src/middlewares/LambdaEventMiddleware.ts @@ -1,6 +1,6 @@ import { HttpRequest } from "../HttpRequest"; import { HttpResponse } from "../HttpResponse"; -import { BeforeMiddleware, HttpCodes } from "../SimpleRouter"; +import { BeforeMiddleware } from "../SimpleRouter"; export class LambdaEventMiddleware implements BeforeMiddleware { async before(request: HttpRequest, response: HttpResponse, context: any) {